Sourcery refactored main branch #3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,16 +19,15 @@ | |
| class exceltoDBtable: | ||
| # Available for sql server and mysql now | ||
| def __init__(self,filePath,hostORip=False,usrID =False,pwd=False,database=False,save2tableName=False): | ||
| if not any([hostORip, database, usrID, pwd]): | ||
| raise Exception("Partially inputs, please check your inputs...") | ||
| self.filePath = filePath | ||
| self.hostORip = hostORip | ||
| self.database=database | ||
| self.usrID = usrID | ||
| self.pwd = pwd | ||
| self.save2tableName = save2tableName | ||
|
|
||
| self.dbType = ["sqlserver"] | ||
| self.readData() | ||
| self.connect2DB() | ||
|
|
@@ -46,27 +45,29 @@ def connect2DB(self) -> "Connect to Database Server": | |
| for i in sqlserverDriver: | ||
| driveString = i.replace(" ","+").replace("{","").replace("}","") | ||
| # print(driveString) | ||
|
|
||
|
|
||
| try: | ||
| self.engine = create_engine( | ||
| f"mssql+pyodbc://{self.usrID}:{self.pwd}@{self.hostORip}/{self.database}?driver={driveString}?" | ||
| ) | ||
|
|
||
| print("Seccessfully connected to SQL Server...") | ||
|
|
||
| if self.save2tableName: | ||
| tableName = self.save2tableName | ||
| elif "/" in self.filePath: | ||
| tableName = self.filePath.split("/")[-1].split(".")[0] | ||
| else: | ||
| tableName = self.filePath.split(".")[0] | ||
|
|
||
| self.file_data.to_sql(tableName,con=self.engine) | ||
| print(f"Successfully saved {tableName} into SQL Server...") | ||
| return None | ||
| except: | ||
| self.engine = False | ||
| continue | ||
|
|
||
|
Comment on lines
-49
to
+70
Author
There was a problem hiding this comment. Function
|
||
| raise Exception("Can not save table to sql server, please check your inputs.") | ||
|
|
||
| def readData(self) -> "DataFrame": | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,16 +19,15 @@ | |
| class exceltoDBtable: | ||
| # Available for sql server and mysql now | ||
| def __init__(self,filePath,hostORip=False,usrID =False,pwd=False,database=False,save2tableName=False): | ||
| if not any([hostORip, database, usrID, pwd]): | ||
| raise Exception("Partially inputs, please check your inputs...") | ||
| self.filePath = filePath | ||
| self.hostORip = hostORip | ||
| self.database=database | ||
| self.usrID = usrID | ||
| self.pwd = pwd | ||
| self.save2tableName = save2tableName | ||
|
|
||
|
Comment on lines
-22
to
+30
Author
There was a problem hiding this comment. Function
|
||
| self.dbType = ["sqlserver"] | ||
| self.readData() | ||
| self.connect2DB() | ||
|
|
@@ -46,27 +45,29 @@ def connect2DB(self) -> "Connect to Database Server": | |
| for i in sqlserverDriver: | ||
| driveString = i.replace(" ","+").replace("{","").replace("}","") | ||
| # print(driveString) | ||
|
|
||
|
|
||
| try: | ||
| self.engine = create_engine( | ||
| f"mssql+pyodbc://{self.usrID}:{self.pwd}@{self.hostORip}/{self.database}?driver={driveString}?" | ||
| ) | ||
|
|
||
| print("Seccessfully connected to SQL Server...") | ||
|
|
||
| if self.save2tableName: | ||
| tableName = self.save2tableName | ||
| elif "/" in self.filePath: | ||
| tableName = self.filePath.split("/")[-1].split(".")[0] | ||
| else: | ||
| tableName = self.filePath.split(".")[0] | ||
|
|
||
| self.file_data.to_sql(tableName,con=self.engine) | ||
| print(f"Successfully saved {tableName} into SQL Server...") | ||
| return None | ||
| except: | ||
| self.engine = False | ||
| continue | ||
|
|
||
|
Comment on lines
-49
to
+70
Author
There was a problem hiding this comment. Function
|
||
| raise Exception("Can not save table to sql server, please check your inputs.") | ||
|
|
||
| def readData(self) -> "DataFrame": | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function
exceltoDBtable.__init__refactored with the following changes:swap-if-else-branches)remove-unnecessary-else)