glslang: improve binaryonly config

[Willaaaaaaa]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @Willaaaaaaa, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the glslang package configuration within xmake.lua by adjusting the default behavior for binary-only builds and standardizing the use of package:is_binary() for conditional logic. These changes streamline the build process, ensuring that the package correctly handles both binary-only and full source builds, optimizing for scenarios where only the pre-compiled tools are required.

Highlights

• Default Binary-Only Configuration: The default value for the binaryonly configuration option for glslang has been changed from false to true. This means that glslang will now default to a binary-only setup.
• Consistent Binary Mode Logic: The xmake.lua script has been updated to consistently use package:is_binary() instead of package:config("binaryonly") across various functions (on_fetch, on_install, on_load). This ensures that conditional logic related to binary builds is applied uniformly.
• Refined Installation Process: The installation logic now differentiates between binary and source builds. When in binary mode, the installation explicitly removes any binaries from the install directory. Conversely, in non-binary mode, it proceeds with copying header files and ensuring the glslangValidator executable is correctly placed.
• Conditional Library Linking and Assertions: Library linking for glslang components (e.g., MachineIndependent, SPIRV) and the assertion for ShInitialize are now conditionally applied only when glslang is not in binary-only mode, aligning with the intent of a source-based build.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves the binaryonly configuration for the glslang package, making it the default behavior. The changes are well-implemented, consistently using package:is_binary() to control the package's behavior for binary-only installations. This refactoring improves clarity and maintainability. The logic correctly adjusts build, installation, and testing steps to either provide only the binaries or a full library build. The changes are sound and improve the package script.