Skip to content
This repository was archived by the owner on Feb 24, 2023. It is now read-only.

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 28, 2022

Bumps lint-staged from 12.3.3 to 13.0.4.

Release notes

Sourced from lint-staged's releases.

v13.0.4

13.0.4 (2022-11-25)

Bug Fixes

  • deps: update all dependencies (336f3b5)
  • deps: update all dependencies (ec995e5)

v13.0.3

13.0.3 (2022-06-24)

Bug Fixes

  • correctly handle git stash when using MSYS2 (#1178) (0d627a5)

v13.0.2

13.0.2 (2022-06-16)

Bug Fixes

  • use new --diff and --diff-filter options when checking task modifications (1a5a66a)

v13.0.1

13.0.1 (2022-06-08)

Bug Fixes

  • correct spelling of "0 files" (f27f1d4)
  • suppress error from process.kill when killing tasks on failure (f2c6bdd)
  • deps: update pidtree@^0.6.0 to fix screen size error in WSL (1a77e42)
  • ignore "No matching pid found" error (cb8a432)
  • prevent possible race condition when killing tasks on failure (bc92aff)

Performance Improvements

  • use EventsEmitter instead of setInterval for killing tasks on failure (c508b46)

v13.0.0

13.0.0 (2022-06-01)

Bug Fixes

  • deps: update execa@^6.1.0 (659c85c)
  • deps: update yaml@^2.1.1 (2750a3d)

... (truncated)

Commits
  • e2bfce1 test: remove Windows snapshot workaround
  • 81ea7fd test: allow file protocol in git submodule test
  • 3ea9b7e test: update Jest snapshot format
  • 0c635c7 ci: install latest npm for older Node.js versions
  • 5f1a00e ci: bump GitHub Actions' versions
  • 336f3b5 fix(deps): update all dependencies
  • ec995e5 fix(deps): update all dependencies
  • 17c51af ci: set GitHub Actions permissions
  • 3f3e152 chore(deps): bump colorette from 2.0.17 to 2.0.19 (#1177)
  • 0d627a5 fix: correctly handle git stash when using MSYS2 (#1178)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [lint-staged](https://github.com/okonet/lint-staged) from 12.3.3 to 13.0.4.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Commits](lint-staged/lint-staged@v12.3.3...v13.0.4)

---
updated-dependencies:
- dependency-name: lint-staged
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 28, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 28, 2022

Dependabot tried to add @GregoireF and @NicolasV as reviewers to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/wr-projects/cz-changelog-wrprojects/pulls/176/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the wr-projects/cz-changelog-wrprojects repository. // See: https://docs.github.com/rest/reference/pulls#request-reviewers-for-a-pull-request

@pull-request-quantifier-deprecated

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +1 -1
Percentile : 0.8%

Total files changed: 2

Change summary by file extension:
.json : +1 -1
.lock : +0 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@dependabot dependabot bot requested review from GregoireF and versnic November 28, 2022 01:10
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 5, 2022

Superseded by #178.

@dependabot dependabot bot closed this Dec 5, 2022
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/lint-staged-13.0.4 branch December 5, 2022 01:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file Extra Small javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants