Add strict slug validation for plugin-tests and theme-tests commands #358
+49
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users pass plugin/theme names with invalid characters to
scaffold plugin-testsorscaffold theme-tests, the generatedbootstrap.phpcontains corrupted file paths like'/my-plugin/.php', causing PHP fatal errors on test execution.Changes
scaffold_plugin_theme_tests()to only allow alphanumeric characters (a-z, A-Z, 0-9) and dashes (-)Example
The validation rejects:
my-plugin/ormy-plugin\my_pluginmy@plugin,my.pluginmy plugin../pluginThe fix follows the existing pattern for invalid slug validation (
.and..) and implements the hard-error approach rather than silently transforming input.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.