Skip to content

Add --format support to language core install command #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Copilot wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add --format support to language core install command #173

Copilot wants to merge 6 commits into from
+94 −1

Conversation

Copy link

Copilot AI commented Dec 24, 2025 •
edited
Loading

  • Understand the existing implementation of --format flag in plugin/theme install commands
  • Add --format parameter to core install command documentation
  • Implement format handling in core install method
  • Add tests for --format flag with core install command
  • Address code review feedback
  • Fix failing test by removing default value from --format parameter
  • Simplify format handling code
  • Run security checks

Summary

This PR successfully adds support for the --format argument to the wp language core install command, matching the functionality implemented for plugin and theme commands in PR #64.

Implementation Details

The implementation:

  • Only outputs formatted results when --format flag is explicitly provided
  • Preserves backward compatibility - commands without --format behave exactly as before
  • Supports table, csv, json, and summary formats
  • Uses quiet logger for csv and json formats to provide clean, parseable output
  • No default value to ensure opt-in behavior

Test Coverage

  • ✅ Added comprehensive Behat tests for all format types
  • ✅ Existing tests pass without modification (backward compatible)
  • ✅ Tests cover CSV, JSON, table, and summary formats
  • ✅ Edge cases like invalid language codes are handled

Code Quality

  • ✅ PHP linting
  • ✅ PHPCS code style
  • ✅ PHPStan static analysis
  • ✅ CodeQL security scan
Original prompt

This section details on the original issue you should resolve

<issue_title>Add support for --format argument to core install command</issue_title>
<issue_description>Support for theme/plugin commands were added in #64. Let's do the same for core install.</issue_description>

Comments on the Issue (you are @copilot in this section)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits December 24, 2025 10:03
@swissspidy
Add --format argument support to core install command
234783f 
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
@swissspidy
Make format parameter optional in docblock type annotation
f6f267d 
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot AI changed the title [WIP] Add support for --format argument to core install command Add --format support to language core install command Dec 24, 2025
Copilot AI requested a review from swissspidy December 24, 2025 10:07
@swissspidy

This comment was marked as resolved.

Sign in to view
@swissspidy
Fix: Only output formatted results when --format flag is explicitly p…
de911ad 
…rovided

The previous implementation always outputted formatted tables, breaking
existing tests. Now format output is only shown when user explicitly
provides --format flag, preserving backward compatibility.

Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copy link
Author

Copilot AI commented Dec 24, 2025

@copilot Failing test:

...

Fixed in de911ad. The issue was that formatted output was being displayed even when --format wasn't explicitly provided. Now the formatted table is only shown when the user provides the --format flag, preserving backward compatibility with existing behavior.

@swissspidy

This comment was marked as resolved.

Sign in to view
Copilot AI and others added 2 commits December 24, 2025 12:54
@swissspidy
Remove default value from --format parameter to prevent auto-population
05894a3 
WP-CLI's parameter parser uses the 'default' value in docblocks to
automatically populate parameters. Removing 'default: table' ensures
--format is only set when explicitly provided by the user, preserving
backward compatibility with existing commands that don't use --format.

Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
@swissspidy
Simplify format handling by removing unnecessary empty check
569ffc8 
Since WP-CLI validates format parameter values, there's no need to
check for empty values and set a default. The format value will always
be valid when isset() returns true.

Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>

This comment was marked as resolved.

Sign in to view
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Core_Language_Command.php 90.90% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy marked this pull request as ready for review December 24, 2025 13:53
@swissspidy swissspidy requested a review from a team as a code owner December 24, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy Awaiting requested review from swissspidy

At least 1 approving review is required to merge this pull request.

Assignees

@swissspidy swissspidy

Copilot code review Copilot

Labels

command:language-core-install scope:distribution state:unconfirmed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for --format argument to core install command

2 participants

@swissspidy