Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.2'
ruby-version: '4.0.0'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: CI workflow (.github/workflows/ci.yml) still tests Ruby 3.1 and 3.2, while release uses 4.0.0 - creates mismatch between test and release environments

Suggested change
ruby-version: '4.0.0'
ruby-version: '3.2'
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 22:22

Comment:
**logic:** CI workflow (`.github/workflows/ci.yml`) still tests Ruby 3.1 and 3.2, while release uses 4.0.0 - creates mismatch between test and release environments

```suggestion
          ruby-version: '3.2'
```

How can I resolve this? If you propose a fix, please make it concise.

bundler-cache: true

- name: Spec
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.1.4
4.0.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Verify all gem dependencies (jwt, encryptor, rubocop, etc.) are compatible with Ruby 4.0.0 before deploying

Prompt To Fix With AI
This is a comment left during a code review.
Path: .ruby-version
Line: 1:1

Comment:
**style:** Verify all gem dependencies (`jwt`, `encryptor`, `rubocop`, etc.) are compatible with Ruby 4.0.0 before deploying

How can I resolve this? If you propose a fix, please make it concise.