Fix size_t issue in test_ecc.c and minor script updates #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padelsbach
requested review from
ColtonWilley and
aidangarske
and removed request for
aidangarske
padelsbach
force-pushed
the
wp-size-t-and-scripts
branch
from
4291ede to
b40c5be
Compare
ColtonWilley
approved these changes
Dec 22, 2025
Contributor
Author
|
jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple loosely related changes:
An
int *(4 bytes) was being cast as asize_t(8 bytes) in test_ecc.c and was causing the unit tests to fail on my machine. I did a quick scan of the provider repo and these were the only cases of this.Minor script improvements for local testing