Skip to content

feat: add suport for mistral3 models #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
albertkawmi wants to merge 3 commits into from
Closed

feat: add suport for mistral3 models #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
305bff6
feat: add suport for `mistral3` models
albertkawmi Dec 3, 2025
7af234f
feat: resolveChatWrapper for mistral3
albertkawmi Dec 4, 2025
d9e8fcd
Revert "feat: resolveChatWrapper for mistral3"
albertkawmi Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/chatWrappers/utils/resolveChatWrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ export function resolveChatWrapper(
return createSpecializedChatWrapper(Llama3_1ChatWrapper);
else if (includesText(modelNames, ["llama 3", "llama-3", "llama3"]))
return createSpecializedChatWrapper(Llama3ChatWrapper);
else if (includesText(modelNames, ["Mistral", "Mistral Large", "Mistral Large Instruct", "Mistral-Large", "Codestral"]))
else if (includesText(modelNames, ["Mistral", "Mistral Large", "Mistral Large Instruct", "Mistral-Large", "Mistral 3", "mistral3", "Ministral", "Codestral"]))
Copy link
Member

@giladgd giladgd Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
else if (includesText(modelNames, ["Mistral", "Mistral Large", "Mistral Large Instruct", "Mistral-Large", "Mistral 3", "mistral3", "Ministral", "Codestral"]))
else if (includesText(modelNames, ["Mistral", "Mistral Large", "Mistral Large Instruct", "Mistral-Large", "Codestral", "Ministral"]))

The first text "Mistral" already includes the "Mistral 3", "mistral3" variations (since the match is case-insensitive)

return createSpecializedChatWrapper(MistralChatWrapper);
else if (includesText(modelNames, ["Gemma", "Gemma 2"]))
return createSpecializedChatWrapper(GemmaChatWrapper);
Expand Down
1 change: 1 addition & 0 deletions src/gguf/types/GgufMetadataTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ export const enum GgufArchitectureType {
grovemoe = "grovemoe",
apertus = "apertus",
cogvlm = "cogvlm",
mistral3 = "mistral3",
clip = "clip",
unknown = "(unknown)"
}
Expand Down