chore: Refactor pre-commit config and test on CI #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
approved these changes
Jan 31, 2025
peterfoldes
approved these changes
Feb 5, 2025
Contributor
Author
|
Thanks! (I don't have merge permissions here, in case anybody was waiting on me to merge this!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the pre-commit in the current repo results in a reformat of
driver.pyand complains about an unused argument when running the mypy hook.This PR switches the formatting to ruff (which was probably the previous formatter, since it results in almost no code changes), adds a few nice-to-haves based on the config in apache/arrow-nanoarrow, and adds a CI job to enforce this in PRs.
Happy to defer to existing opinions if I reverted something that had a specific reason for existing!