-
Notifications
You must be signed in to change notification settings - Fork 260
Fix on main branch to make navigation events with the Gtk WebView (GtkWebKit) work as expected. #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
to do. When one calls webui_show* manually all is loaded. Interaction from within the HTML by clicks, javascript, etc. is catched. Signed-off-by: Hans Dijkema <hans@dijkewijk.nl>
called to catch all navigation events. Signed-off-by: Hans Dijkema <hans@dijkewijk.nl>
… inline functions)
|
Thank you for the fix.
Please let me know if this modification does not break your fix. |
|
I'll look into it coming as soon as possible, maybe later this evening. Looks good though. Funny. I started with static inline functions instead of macro's, and went back to macro's and now you moved back to static inline functions. Why did gcc fail to build? I'm working with gcc on linux. Mingw32? |
|
Both are fine, we just pick whatever can be fixed faster. The errors are here: |
I think I see what's wrong there: (if (win->webView && win->has_all_events) win->webView->in_show = status)may not be to gcc's liking, because of the parentheses.
|
Please feel free to update any part of the code as I'm editing the code without testing. |
Yes, definitely the parentheses, but we can keep the inline functions for now as both give the same results. It's just a question about where is the best place to call |
|
I'm sorry, I replaced them again with a #define. I'll try to explain my current solution in the next pull request. |


With these changes, I think the navigation eventing works as one would expect it
to do. When one calls webui_show* manually all is loaded. Interaction from
within the HTML by clicks, javascript, etc. is catched.