feat: Browser profile enhancements #3024
Conversation
- Improves fetch performance for crawler proxies and channels, fixing `crawler-channels` being called twice wherever channel selector is rendered - Fixes empty space when only single channel is available - Hides `(Exact Crawler Version)` text when version is not available
- Fixes browser profile list UI inconsistencies - Displays whether profile is in use in list - Adds "Mine" filter
This change is a rewrite of the browser profile detail page UI to support a consistent UX flow for creating and configuring profiles. Additional features: - Displays workflows associated with browser profile and enables filtering by failed due to not logged in - Enables changing crawler channel on profile - Easily add site to profile - Displays when and how a profile was last modified
- Allows users to set tags on browser profiles - Allows users to filter browser profiles by tag - Refactors `workflow-tag-filter` and `archived-item-tag-filter` into single `tag-filter`
- Updates browser profile dialogs to organize settings into separate "Crawler Settings" section - Allows users to replace saved sites with new site - Fixes browser site list loading state - Consistently displays profile URLs
- Replaces redundant "Go to workflow" menu item in browser profile workflow list with "Load Crawl Start URL". - Fixes not being able to open a workflow in a new tab (#3001) - Adds suggestions to site dropdown
- Limits tag input to 40 characters - Determines maximum tags displayed by container width
- Updates browser profile and workflow form controls to make relationship between profile and proxy more apparent - Displays suggested browser profiles based on workflow seed URLs - Displays browser profile details when selecting a profile from a workflow - Fixes profile not saved to crawling defaults - Consistency fixes for how proxies and crawler release channel is displayed --------- Co-authored-by: Ilya Kreymer <ikreymer@gmail.com>
SuaYoo
changed the title
- Fixes edge case where profile without valid origin can be saved - Handles edge case of no saved sites, since backend does not currently prevent saving profiles without any origins
ikreymer
left a comment
ikreymer
left a comment
There was a problem hiding this comment.
Looking good! Tested incrementally and on this branch. Significant improvement over the existing profile UX!
|
Working great! I noticed that if I load a new profile with https://old.webrecorder.net, the Save Profile button remains disabled with a tooltip saying that I need to wait until the page fully loads. This doesn't seem to resolve until I visit another URL. That may be something unique to old.webrecorder.net (which, without a login function, is not at all representative of a typical single site to visit for a profile), but perhaps worth testing with more sites to see if this an indication that other sites may have issues as well. |
This would be an issue in the crawler, it's just waiting for first origin to be reported, which crawler should report on first page |
I'm now unable to reproduce the issue, attempts to load the site in a profile browser are now working fine. Might have just been something to do with my local development environment. |
|
Ah ok, now I was able to repro a frontend issue, there is a site there, but button is still disabled: It does get reenabled only when another origin is added. Edit: Fixed via #3030 |
- Allows users to filter browser profile list by name - Fixes layout inconsistencies with browser profiles list --------- Co-authored-by: Emma Segal-Grossman <hi@emma.cafe>
- Fix for 'Create Profile' button sometimes not being enabled due to event not firing, see: #3024 (comment) - Ensure that if origins are loaded before browser is ready, both are checked separately.
Resolves #2936.
This PR is open for final manual testing and should be merged as distinct commits.
See individual PRs for a list of changes.
Manual testing
Test the following: