Skip to content

Conversation

@AndrewRayCode
Copy link

Copying #232 to test

Solves webpack#231 and updates the README to match.
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid it is a breaking change, I am fine this, but under the option

@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 61.29032% with 12 lines in your changes missing coverage. Please review.

Project coverage is 90.54%. Comparing base (33df387) to head (26b32cb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/DirectoryWatcher.js 61.29% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   92.20%   90.54%   -1.66%     
==========================================
  Files           6        6              
  Lines        1065     1079      +14     
  Branches      258      264       +6     
==========================================
- Hits          982      977       -5     
- Misses         83      102      +19     
Flag Coverage Δ
integration 90.54% <61.29%> (-1.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ArjhanToteck
Copy link

at this point it might be best to only follow symlinks when not using polling, that seems to be what breaks the symlinks. it's better than nothing I guess

@alexander-akait
Copy link
Member

@AndrewRayCode I still think we should polling for such cases too, do you try to look why test were failed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants