Skip to content
This repository was archived by the owner on Apr 29, 2024. It is now read-only.

Conversation

@ksy36
Copy link
Contributor

@ksy36 ksy36 commented Jul 21, 2022

Screen Shot 2022-07-21 at 1 44 57 PM

@ksy36
Copy link
Contributor Author

ksy36 commented Jul 21, 2022

I'm in between medium and large, as it affects a few important sites in Japan and one in Netherlands, but not sure whether they're "very popular".

@jgraham
Copy link
Contributor

jgraham commented Jul 22, 2022

The spreadsheet here is very nice; I'm starting to think we should bite the bullet and put that information in the kb directly (affected domain, platform, notes on impact, last reproduced date, has intervention, notes). The site rankings we could presumably pull directly from the Tranco API given the domain, and then we could compute the serverity from those inputs.

Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is somewhere between medium and large, and it makes more sense to err on the side of large.

Copy link
Member

@denschub denschub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing investigation. I agree with everything said, and just like James, I too would err on the side of the larger value. :)

@ksy36
Copy link
Contributor Author

ksy36 commented Jul 22, 2022

Thanks for the feedback :) Thinking to wait for #71 to be merged and then add the data from the spreadsheet to the breakage section.

@ksy36 ksy36 force-pushed the issues/zoom-css-ubi branch 2 times, most recently from 9a6e9c1 to 40f0d21 Compare July 28, 2022 19:28
@ksy36 ksy36 force-pushed the issues/zoom-css-ubi branch from 40f0d21 to a321c7c Compare July 28, 2022 19:32
@ksy36 ksy36 changed the title Add user_base_impact for zoom css Add user_base_impact and detailed breakage for zoom css Jul 28, 2022
@ksy36
Copy link
Contributor Author

ksy36 commented Jul 28, 2022

I've added the detailed breakage, should be ready for review now :)

@ksy36 ksy36 requested review from denschub and jgraham July 28, 2022 23:57
Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jgraham jgraham merged commit c4d7424 into main Jul 29, 2022
@jgraham jgraham deleted the issues/zoom-css-ubi branch July 29, 2022 08:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants