-
Notifications
You must be signed in to change notification settings - Fork 1
Add user_base_impact and detailed breakage for zoom css #69
Conversation
ksy36
commented
Jul 21, 2022

|
I'm in between |
|
The spreadsheet here is very nice; I'm starting to think we should bite the bullet and put that information in the kb directly (affected domain, platform, notes on impact, last reproduced date, has intervention, notes). The site rankings we could presumably pull directly from the Tranco API given the domain, and then we could compute the serverity from those inputs. |
jgraham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this is somewhere between medium and large, and it makes more sense to err on the side of large.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing investigation. I agree with everything said, and just like James, I too would err on the side of the larger value. :)
|
Thanks for the feedback :) Thinking to wait for #71 to be merged and then add the data from the spreadsheet to the breakage section. |
9a6e9c1 to
40f0d21
Compare
40f0d21 to
a321c7c
Compare
|
I've added the detailed breakage, should be ready for review now :) |
jgraham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!