refactor(android-playground): refactor getAdbDevices to use getConnectedDevices for improved device retrieval #1518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tedDevices for improved device retrieval
✅ Deploy Preview for midscene ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Copilot finished reviewing on behalf of
lhuanyu
November 28, 2025 13:57
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
quanru
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the logic for retrieving connected Android devices in the
packages/android-playground/src/bin.tsfile. The main improvement is replacing manual ADB command parsing with the standardizedgetConnectedDevicesutility from@midscene/android, resulting in cleaner and more maintainable code.Device discovery improvements:
getAdbDeviceswith thegetConnectedDevicesfunction from@midscene/android, ensuring more reliable and consistent device information retrieval.getConnectedDevicesfrom@midscene/android, removing the need for direct ADB command usage.