Skip to content

Conversation

@edison1105
Copy link
Member

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Dec 2, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/feat/SuspenseInterop

Comment @coderabbitai help to get the list of available commands and usage tips.

@edison1105 edison1105 mentioned this pull request Dec 2, 2025
20 tasks
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 85.2 kB 29.9 kB 26.4 kB
runtime-dom.global.prod.js 108 kB (-4 B) 40.5 kB (-15 B) 36.4 kB (-9 B)
vue.global.prod.js 166 kB (-4 B) 60.5 kB (-16 B) 53.8 kB (+41 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.2 kB (+179 B) 18.8 kB (+66 B) 17.2 kB (+77 B)
createApp 57.2 kB (+179 B) 22 kB (+73 B) 20.1 kB (+74 B)
createApp + vaporInteropPlugin 96 kB (+625 B) 35.4 kB (+270 B) 31.9 kB (+199 B)
createVaporApp 41 kB (+471 B) 15.2 kB (+164 B) 13.9 kB (+156 B)
createSSRApp 61.6 kB (+176 B) 23.8 kB (+68 B) 21.7 kB (+62 B)
defineCustomElement 63.3 kB (+179 B) 23.8 kB (+71 B) 21.7 kB (+68 B)
overall 71.9 kB (-240 B) 27.2 kB (-108 B) 24.8 kB (-77 B)

@edison1105 edison1105 added the scope: vapor related to vapor mode label Dec 2, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 2, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@14157

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@14157

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@14157

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@14157

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@14157

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@14157

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@14157

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@14157

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@14157

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@14157

@vue/shared

npm i https://pkg.pr.new/@vue/shared@14157

vue

npm i https://pkg.pr.new/vue@14157

@vue/compat

npm i https://pkg.pr.new/@vue/compat@14157

commit: 00b0561

@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Dec 2, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
pinia success success
nuxt failure success
radix-vue success success
test-utils failure success
router failure failure
vue-i18n success failure
vite-plugin-vue success success
language-tools success success
vuetify failure failure
vant success success
vue-macros failure failure
vueuse failure success
vitepress success success
vue-simple-compiler success success
quasar success success
primevue success success

Copilot AI review requested due to automatic review settings December 4, 2025 00:47
Copilot finished reviewing on behalf of edison1105 December 4, 2025 00:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for rendering vapor components within vdom Suspense boundaries by propagating the parent suspense context through the interop layer and handling async setup in vapor components.

  • Adds parentSuspense parameter to vdom interop mount/hydrate methods
  • Implements suspense context management for vapor components with async setup
  • Extracts handleSetupResult logic into a reusable function to support async resolution

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/runtime-vapor/src/vdomInterop.ts Adds parentSuspense parameter to mount/hydrate methods and implements suspense context save/restore logic; guards unmount for unresolved async components
packages/runtime-vapor/src/components/Suspense.ts New file implementing setParentSuspense for managing global suspense context and placeholder for VaporSuspenseImpl
packages/runtime-vapor/src/component.ts Adds async setup detection, suspense-related instance properties, and extracts handleSetupResult function; handles async deps in mountComponent
packages/runtime-vapor/tests/components/Suspense.spec.ts Comprehensive test coverage for vdom Suspense with vapor components including nested async components and unmounting scenarios
packages/runtime-core/src/renderer.ts Refactors registerDep callback to use new simplified interface, delegates setup result handling to callback
packages/runtime-core/src/hydration.ts Adds parentSuspense parameter to hydration interop calls
packages/runtime-core/src/components/Suspense.ts Updates registerDep interface to accept generic onResolve callback instead of render-specific parameters
packages/runtime-core/src/component.ts Adds interface definitions for suspense-related properties on component instances
packages/runtime-core/src/apiCreateApp.ts Updates VaporInteropInterface to include parentSuspense parameter in method signatures

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@edison1105 edison1105 changed the title feat: vdom Suspense render vapor components feat(suspense): support rendering of Vapor components Dec 4, 2025
@edison1105 edison1105 merged commit 0dcc98f into minor Dec 4, 2025
17 checks passed
@edison1105 edison1105 deleted the edison/feat/SuspenseInterop branch December 4, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: vapor related to vapor mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants