Skip to content

Conversation

@zhiyuanzmj
Copy link
Member

Instead of #13395.

@coderabbitai
Copy link

coderabbitai bot commented Nov 6, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84.9 kB 29.8 kB 26.3 kB
runtime-dom.global.prod.js 107 kB 40.2 kB 36.2 kB
vue.global.prod.js 165 kB 60.1 kB 53.5 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.9 kB 18.7 kB 17.1 kB
createApp 57 kB 21.9 kB 20 kB
createApp + vaporInteropPlugin 90.4 kB 33.8 kB 30.5 kB
createVaporApp 34 kB 13 kB 11.9 kB
createSSRApp 61.3 kB 23.7 kB 21.6 kB
defineCustomElement 62.6 kB 23.6 kB 21.5 kB
overall 72.1 kB 27.3 kB 24.9 kB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 6, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@14061

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@14061

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@14061

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@14061

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@14061

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@14061

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@14061

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@14061

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@14061

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@14061

@vue/shared

npm i https://pkg.pr.new/@vue/shared@14061

vue

npm i https://pkg.pr.new/vue@14061

@vue/compat

npm i https://pkg.pr.new/@vue/compat@14061

commit: 9d4d95e

@edison1105 edison1105 added version: minor scope: vapor related to vapor mode labels Nov 6, 2025
@edison1105 edison1105 moved this to Vapor in Next Minor Nov 6, 2025
@AaronDewes
Copy link

In my testing, Vapor does not seem to be affected by #14060 (I don't know why, but I commented a playground link on the original issue). Is there a case where this fix is still necessary?

@zhiyuanzmj
Copy link
Member Author

We should not delete users expression, adding parentheses instead is safe.
e.g.

<div :foo="toNumber(`${foo}`)!" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: vapor related to vapor mode version: minor

Projects

Status: Vapor

Development

Successfully merging this pull request may close these issues.

3 participants