Skip to content

fix(runtime-core): guard prop validator against invalid types to avoid instanceof crash (fix #14041) #14042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+26 −18
Open

fix(runtime-core): guard prop validator against invalid types to avoid instanceof crash (fix #14041) #14042

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5586cda
fix(runtime-core): guard prop validator to avoid instanceof crash
Oct 31, 2025
5603aca
refactor(runtime-core): handle null type check before assertType
ZKunZhang Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/runtime-core/src/componentProps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,14 +737,19 @@ function assertType(
valid = t === expectedType.toLowerCase()
// for primitive wrapper objects
if (!valid && t === 'object') {
valid = value instanceof (type as PropConstructor)
// Guard against invalid prop type definitions (e.g. 'object', {}, etc.)
Copy link
Member

@edison1105 edison1105 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proper fix should be to avoid calling assertType if type is a null-lish value (at line:700)

Copy link
Author

@ZKunZhang ZKunZhang Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proper fix should be to avoid calling assertType if type is a null-lish value (at line:700)

Sorry, I misunderstood the meaning. I'll fix it right now

// Only attempt instanceof when the provided type is a function/constructor.
valid = isFunction(type) && value instanceof (type as PropConstructor)
}
} else if (expectedType === 'Object') {
valid = isObject(value)
} else if (expectedType === 'Array') {
valid = isArray(value)
} else {
valid = value instanceof (type as PropConstructor)
// Fallback to constructor check only when type is a function.
// This avoids errors like "Right-hand side of 'instanceof' is not an object"
// when users mistakenly pass invalid values (e.g. strings) in prop type.
valid = isFunction(type) && value instanceof (type as PropConstructor)
}
return {
valid,
Expand Down