Skip to content

fix: networkd is not an internal service #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vchepkov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: networkd is not an internal service #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/init.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@
Class['systemd::install'] -> Class['systemd::resolved']
}

if $manage_networkd and $facts['systemd_internal_services'] and $facts['systemd_internal_services']['systemd-networkd.service'] {
if $manage_networkd {
contain systemd::networkd
Class['systemd::install'] -> Class['systemd::networkd']
}
Expand Down
2 changes: 1 addition & 1 deletion manifests/network.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
) {
include systemd

if $restart_service and $systemd::manage_networkd and $facts['systemd_internal_services'] and $facts['systemd_internal_services']['systemd-networkd.service'] {
if $restart_service and $systemd::manage_networkd {
$notify = Service['systemd-networkd']
} else {
Copy link
Contributor

@trefzer trefzer Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you can also change that if/else to

File["${path}/${name}"] ~> Service['systemd-networkd']

So no else needed, and remove the notify line (line 52).

$notify = undef
Expand Down
Loading