Draft: add .node_version fallback #1974
Conversation
|
@chriskrycho what do you think about support I didn't want to distract you, but it's very interesting. Sorry:) |
| let project_path = manifest_file.parent()?; | ||
|
|
||
| match std::fs::read_to_string(project_path.join(".node_version")) { | ||
| Ok(version) => match Version::parse(version) { |
There was a problem hiding this comment.
How Version::parse resolves ranges?
22 > 22.0.0?
There was a problem hiding this comment.
There will be a error in the current draft. It won't be difficult to add the latest available version.
There was a problem hiding this comment.
@easymikey What needs to be done for this to be merged?
There was a problem hiding this comment.
I can implement this logic on Monday, if needed quickly. But do you know if mentainers can merge it?
|
Please make this happen! 🎈 |
|
@easymikey thanks for working on this!! I think we might need to do an RFC for this, just to make sure we nail the interop details (and error cases). I don't think that needs to be a super long and drawn out process (not sure how @charlespierce, @chriskrycho, &c feel but this feels both important and straight forward). I think a great place to start would be taking the prose from https://github.com/volta-cli/rfcs/blob/main/text/0010-node-version-resolution.md and working to update it to allow |
|
@rwjblue Thank you for your reply! I created a draft for an RFC: volta-cli/rfcs#54 Just let me know if there's anything else I can do to help this move forward. |
|
Opened PR: #2007 |
|
@andreassjoberg respects. Unfortunately, I was never able to get the implementation. Thanks for thinking of idea and for implementing it🙂 |
4 participants
#1973
implemented a small draft