Skip to content

Conversation

@ywang96
Copy link
Member

@ywang96 ywang96 commented Nov 27, 2025

Purpose

Carried over work from #29425 with another bugfix on t_index - thanks to @sergey-tc for pointing it out!
Co-authored by: grider-transwithai grider@transwith.ai

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Co-authored by: grider-transwithai <grider@transwith.ai>

Signed-off-by: Roger Wang <hey@rogerw.io>
Signed-off-by: Roger Wang <hey@rogerw.io>
@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 27, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix a bug in HunyuanVL's XD-RoPE implementation. My review found a critical issue in vllm/model_executor/models/hunyuan_vision.py where the h_index for positional embeddings is being incorrectly overwritten. It seems to be a typo, and the fix was likely intended for t_index. I've provided a suggestion to correct this. The change in vllm/transformers_utils/processors/hunyuan_vl_image.py correctly fixes a bug in image resizing logic.

@ywang96 ywang96 merged commit cf348c8 into vllm-project:main Nov 27, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants