-
-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[BugFix] Fix new nightly failures #29578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix new nightly failures #29578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses several nightly failures by correcting the shape of a dummy block table and introducing an unpadded method to handle attention metadata for speculative decoding. The block table shape fix is a critical correction. I've also suggested an improvement to the unpadded method to ensure metadata correctness by recomputing max_query_len and max_seq_len for the unpadded data, which is important for correctness and performance.
8c359e0 to
f8fe350
Compare
|
The doc build failure is unrelated and fixed by #29619 |
Fix nightly failures:
Caused by #28579
All tests above pass; running
ready-run-all-tests