Skip to content

Conversation

@LucasWilkinson
Copy link
Collaborator

@LucasWilkinson LucasWilkinson commented Nov 27, 2025

Fix nightly failures:

tests/models/language/pooling_mteb_test/test_jina.py::test_embed_models_mteb[model_info0]
tests/models/language/pooling/test_token_classification.py::test_modernbert_models[float-disham993/electrical-ner-ModernBERT-base]
tests/models/language/pooling_mteb_test/test_st_projector.py::test_embed_models_mteb[model_info1]
tests/models/multimodal/pooling/test_siglip.py::test_models_text[float-google/siglip-base-patch16-224]
tests/models/multimodal/pooling/test_siglip.py::test_models_text[float-google/siglip2-base-patch16-224]
tests/models/multimodal/pooling/test_siglip.py::test_models_text_image_no_crash[float-google/siglip-base-patch16-224]
tests/models/multimodal/pooling/test_siglip.py::test_models_text_image_no_crash[float-google/siglip2-base-patch16-224]
examples/offline_inference/spec_decode.py --test --method eagle --num_spec_tokens 3 --dataset-name hf --dataset-path philschmid/mt-bench --num-prompts 80 --temp 0 --top-p 1.0 --top-k -1 --tp 1 --enable-chunked-prefill --max-model-len 2048

Caused by #28579

All tests above pass; running ready-run-all-tests

@LucasWilkinson LucasWilkinson added the ready-run-all-tests Trigger CI with all tests for wide-ranging PRs label Nov 27, 2025
@mergify mergify bot added the v1 label Nov 27, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses several nightly failures by correcting the shape of a dummy block table and introducing an unpadded method to handle attention metadata for speculative decoding. The block table shape fix is a critical correction. I've also suggested an improvement to the unpadded method to ensure metadata correctness by recomputing max_query_len and max_seq_len for the unpadded data, which is important for correctness and performance.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 27, 2025
Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
@LucasWilkinson LucasWilkinson force-pushed the lwilkinson/nightly-fixes branch from 8c359e0 to f8fe350 Compare November 27, 2025 15:51
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 27, 2025 15:58
@DarkLight1337
Copy link
Member

DarkLight1337 commented Nov 27, 2025

The doc build failure is unrelated and fixed by #29619

@vllm-bot vllm-bot merged commit be493e0 into vllm-project:main Nov 27, 2025
129 of 134 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed ready-run-all-tests Trigger CI with all tests for wide-ranging PRs v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants