[CI/Build] Skip ray tests on ROCm #29556
Open
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR skips tests with ray as the distributed executor backend on ROCm, in order to make the AMD run of the testgroup Distributed Tests (2 GPUs) slightly more successful.
Setting ray as distributed backend executor in vLLM fails on ROCm due to how ray manages GPU resources, how vLLM allocates resources via ray and how importing torch on ROCm caches the value of
CUDA_VISIBLE_DEVICES. Ray manages GPU resources per actor withCUDA_VISIBLE_DEVICES, but vLLM doesn't bundle a GPU resource with a CPU resource when spawning aDPEngineCoreActorand consequently must set that value at runtime. Unfortunately for the ROCm flow,CUDA_VISIBLE_DEVICES=""is cached upon importing torch and subsequent value changes won't convince torch that any GPUs are available on the system, resulting in an error.Setting
RAY_ACCEL_ENV_VAR_OVERRIDE_ON_ZERO=0such that ray won't setCUDA_VISIBLE_DEVICES=""for GPU-less actors also fails due to collisions.Test Plan
In the tests directory using the ROCm docker image,
TP_SIZE=1 DP_SIZE=2 pytest -s -v v1/distributed/test_async_llm_dp.py::test_load.Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.