-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[Attention] Update attention imports #29540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Attention] Update attention imports #29540
Conversation
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a large-scale refactoring that removes lazy imports and TYPE_CHECKING blocks related to attention backends throughout the codebase. The changes are consistent and correctly applied, moving imports to the top level and updating type hints accordingly. This cleanup improves code readability and structure. I have reviewed all the changes and found no issues. The refactoring appears to be safe and well-executed.
|
cc @mgoin |
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
yewentao256
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work! Let's run CI and see if we can pass
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
|
It's worth noting that the |
LucasWilkinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for doing this!
yewentao256
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the work!
yeah I am not really sure it was worth changing 40 files for that |
Purpose
Now that #29342 has landed, many of the
TYPE_CHECKINGand lazy imports are no longer necessary. This PR updates them throughout the codebaseTest Plan
Recommend to run all CI tests (
ready-run-all-tests)Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.