Skip to content

Conversation

@Potabk
Copy link
Collaborator

@Potabk Potabk commented Nov 7, 2025

What this PR does / why we need it?

This patch aims to integrate the mooncake v0.3.7.2.post2 to vllm-ascend images

Does this PR introduce any user-facing change?

How was this patch tested?

Test is locally:

docker build -t vllm-ascend-with-mooncake -f Dockerfile.a3 --network host .

Start the container after build is complete:

IMAGE=vllm-ascend-with-mooncake
docker run --rm \
--name test_nightly \
--device /dev/davinci2 \
--device /dev/davinci_manager \
--device /dev/devmm_svm \
--device /dev/hisi_hdc \
-v /usr/local/dcmi:/usr/local/dcmi \
-v /usr/local/Ascend/driver/tools/hccn_tool:/usr/local/Ascend/driver/tools/hccn_tool \
-v /usr/local/bin/npu-smi:/usr/local/bin/npu-smi \
-v /usr/local/Ascend/driver/lib64/:/usr/local/Ascend/driver/lib64/ \
-v /usr/local/Ascend/driver/version.info:/usr/local/Ascend/driver/version.info \
-v /etc/ascend_install.info:/etc/ascend_install.info \
-v /root/.cache:/root/.cache \
-it $IMAGE bash

test mooncake:

>>> from mooncake.engine import TransferEngine
>>> import mooncake

Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Signed-off-by: wangli <wangli858794774@gmail.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates Mooncake into the vllm-ascend base images by updating several Dockerfiles and adding a new installer script. While the goal is clear, the implementation introduces several inefficiencies in the Docker build process and a few critical bugs in the new installer script. My review focuses on optimizing the Dockerfiles for smaller image size and faster builds by consolidating package installation steps, and on fixing critical issues in the installer script related to incorrect directory handling, flawed error checking, and ineffective environment variable management.

Signed-off-by: wangli <wangli858794774@gmail.com>
@Potabk Potabk requested review from wangxiyuan and wxsIcey November 7, 2025 09:29
@Yikun Yikun added ready read for review ready-for-test start test by label for PR labels Nov 7, 2025
oc)

Signed-off-by: wangli <wangli858794774@gmail.com>
@Potabk Potabk added ready read for review ready-for-test start test by label for PR and removed ready read for review ready-for-test start test by label for PR labels Nov 10, 2025
Signed-off-by: wangli <wangli858794774@gmail.com>
@Potabk Potabk added ready read for review ready-for-test start test by label for PR and removed ready read for review ready-for-test start test by label for PR labels Nov 10, 2025
Signed-off-by: wangli <wangli858794774@gmail.com>
@Potabk Potabk removed the ready read for review label Nov 11, 2025
@Potabk Potabk added ready read for review ready-for-test start test by label for PR and removed ready-for-test start test by label for PR ready read for review labels Nov 11, 2025
Signed-off-by: wangli <wangli858794774@gmail.com>
@Potabk Potabk added ready read for review ready-for-test start test by label for PR and removed ready read for review ready-for-test start test by label for PR labels Nov 11, 2025
@wangxiyuan wangxiyuan merged commit 9cc4222 into vllm-project:main Nov 11, 2025
35 of 40 checks passed
@Potabk Potabk deleted the inter_mooncake branch November 11, 2025 08:18
luolun pushed a commit to luolun/vllm-ascend that referenced this pull request Nov 19, 2025
### What this PR does / why we need it?
This patch aims to integrate the mooncake
[v0.3.7.2.post2](https://github.com/kvcache-ai/Mooncake/releases/tag/v0.3.7.post2)
to vllm-ascend images

- vLLM version: v0.11.0
- vLLM main:
vllm-project/vllm@83f478b

---------

Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: luolun <luolun1995@cmbchina.com>
hwhaokun pushed a commit to hwhaokun/vllm-ascend that referenced this pull request Nov 19, 2025
### What this PR does / why we need it?
This patch aims to integrate the mooncake
[v0.3.7.2.post2](https://github.com/kvcache-ai/Mooncake/releases/tag/v0.3.7.post2)
to vllm-ascend images

- vLLM version: v0.11.0
- vLLM main:
vllm-project/vllm@83f478b

---------

Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: hwhaokun <haokun0405@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:tools ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants