Skip to content

ci: post comments when coverage fails #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2024
Merged

ci: post comments when coverage fails #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f8167c
update
vladopajic Nov 17, 2024
a0c92da
test fail ci
vladopajic Nov 17, 2024
cfbcf22
revert test change + docs
vladopajic Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ jobs:
- name: check test coverage
id: coverage
uses: vladopajic/go-test-coverage@v2
continue-on-error: true # Should fail after coverage comment is posted
with:
config: ./.github/.testcoverage.yml
profile: cover.ubuntu-latest.profile,cover.macos-latest.profile
Expand Down Expand Up @@ -88,4 +89,9 @@ jobs:
```
${{ fromJSON(steps.coverage.outputs.report) }}
```
edit-mode: replace
edit-mode: replace

- name: "finally check coverage"
if: steps.coverage.outcome == 'failure'
shell: bash
run: echo "coverage check failed" && exit 1
6 changes: 6 additions & 0 deletions docs/github_action.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ Here is an example of how to post comments with the coverage report to your pull
- name: check test coverage
id: coverage
uses: vladopajic/go-test-coverage@v2
continue-on-error: true # Should fail after coverage comment is posted
with:
config: ./.github/.testcoverage.yml

Expand Down Expand Up @@ -84,4 +85,9 @@ Here is an example of how to post comments with the coverage report to your pull
${{ fromJSON(steps.coverage.outputs.report) }}
```
edit-mode: replace

- name: "finally check coverage"
if: steps.coverage.outcome == 'failure'
shell: bash
run: echo "coverage check failed" && exit 1
```
Loading