feat: use common testing library svelte core #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR (finally) follows up on #3 - sorry it took so long! (New job, baby on the way, usual free-time excuses 🙈). It also addresses #19
Note
The
@testing-library/svelte-coreis still in pre-release while I run it through its paces.I'll keep this PR as a draft until the stable
v1is releasedDetails
This PR introduces
@testing-library/svelte-coreas a dependency. This module has no dependencies other than a peer dependency on Svelte, and is the rendering and cleanup logic extracted from@testing-library/svelte, without any reliance on@testing-library/domAdding this dependency allows the removal of all the soft-fork code
Follow up work
After this PR, it might be worth updating the build process of this module to build types with
tscortsupinstead of keeping the types files in sync by hand - or maybe even switching the module to TS. Let me know if that's something that would be helpful for me to put up a PR for!