Fix the version string for PEP440, and some Qt6 enum accesses #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues I encountered attempting to install and run
videomorphfrom the repo sources:1.5-canelodoesn't conform to PEP440, and is therefore invalid.pip installwill abort with a traceback due to apackaging.version.InvalidVersionexception. But,1.5+canelois perfectly valid, so use that instead.QAbstractItemView.EditTriggerinstead ofQAbstractItemView; Model roles are now members ofQt.ItemDataRole; TheQMessageBox"OK" button is now found atQMessageBox.StandardButton.Ok.I can't promise I got all of the enum access issues, in the second commit, there could be more. I addressed only the ones I either personally experienced, or saw were guilty of the same issue that caused problems for me.
Also, NOT addressed in this PR is another crash I hit in the converter, specifically in
converter.reader.OutputReader.bitratedue to anIndexError:So, it looks like additional defensive coding and sanity checks are needed there.