Skip to content

Conversation

@wangduanduan
Copy link

@wangduanduan wangduanduan commented Sep 14, 2023

when jssip receivce NOTIFY (in dialog) before call answer, jssip reply with 403 Wrong Status.

but we want to use in-dialog NOTIFY

the code below is my in app , no in jssip

myPhone.on('newRTCSession', ({ session, originator, request })=>{

    session.on('sipEvent', (e) => {
       
    })
})

@markusatm
Copy link
Contributor

There's already a pending pull request I created for this two years ago: #748
I recommend using that one since it fully implements it and makes it optional. Always simply accepting a call if a "talk" notify arrives is a security risk.

@wangduanduan
Copy link
Author

wangduanduan commented Sep 14, 2023

@markusatm but why they not accepted your pull request for two years! 😂. #748

@ibc
Copy link
Member

ibc commented Sep 14, 2023

We will address pending PRs when we are less busy, but indeed this PR is no valid due to above given rationale.

@wangduanduan
Copy link
Author

@markusatm

I just need the sipEvent in dialog, maybe not answer call

@ibc ibc closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants