Subscribe support #711

ikq · 2021-05-20T15:21:07Z

I added Subscriber.js Notifier.js to JsSIP

I tried write them according JsSIP style and lint errors.
Please take a look and let me know what needs to be fixed.

I already see that *.d.ts files are missing.

The work still in progress: I want add to SUBSCRIBE Contact +sip.instance
as you do in REGISTER

… subscribe_support

jmillan · 2021-05-21T05:57:27Z

Hi @ikq,

JsSIP code must have the same style in order to make it readable and maintainable. Comments before making a deeper review:

Debug line as the first method call in al public method implementations.
New line after return.
New line before and after call to super().
First conditional in a block starts in new line and last ends in a new line.
Conditional blocks always contain curly brackets.
Comments in the line above when possible.
Calls to debug have usually a new line above and a new line below.

Please take a certain file (ie: RTCSession.js) as a reference and try to stick to its style.

… subscribe_support

jmillan · 2021-05-25T06:25:11Z

@ikq

Thanks for the cleanup, 👍 We'll review the PR as we can.

devoxy1 · 2023-11-15T07:36:20Z

@jmillan Would it be possible to review again? Thanks!

devoxy1 · 2023-11-28T09:59:02Z

Kind reminder

devoxy1 · 2023-12-05T15:16:03Z

Up!

ddyner · 2023-12-10T11:23:27Z

Hello. We also want to use this feature. Will this pull request be merged?

jmillan · 2023-12-11T13:34:35Z

This is waiting for the docs to be generated. @ikq are you willing to create a PR for the doc? We cannot merge the feature without it.

ikq · 2023-12-11T14:54:41Z

Writing documentation is never easy for me but let's try.

How do you do this?

I have to download the zip (or git clone) from https://github.com/versatica/jssip.net,

install nanoc and modify content/documentation/api/ua.html

And then check the result using nanoc compile, nanoc view?

If the modified doc compiled, make Pull Request of https://github.com/versatica/jssip.net with

modified api/ua.html,
and created api.subscriber.html, api.notifier.html

Do I understand correctly ?

ikq · 2023-12-17T18:18:42Z

I created pull request for https://github.com/versatica/jssip.net
Please take a look.

devoxy1 · 2024-01-09T09:06:54Z

@jmillan Hello! Could you please check it up? Thank you!

jmillan · 2024-01-09T09:22:06Z

I'll review when I can. If you are in a hurry, please do use this branch freely.

jmillan · 2024-01-09T09:23:20Z

I'll review when I can. If you are in a hurry, please do use this branch freely.

This way you will also collaborate on using, testing and reporting.

devoxy1 · 2024-01-09T11:32:34Z

@jmillan We already using it this way :) but it's a bit difficult to maintain separate branch.
Anyways, thanks you!

jmillan · 2024-01-18T10:25:40Z

I'm not forgetting about this...,

devoxy1 · 2024-03-28T13:03:21Z

@jmillan Hello! Any chance you had time to review this one?
Thanks!

orgads · 2024-07-23T14:16:29Z

@jmillan Ping?

jmillan · 2024-07-29T10:32:25Z

For those willing to use this feature I would suggest you use this branch. I don't have at the moment the resources to re-check and merge this, so please, do use this branch for the time being.

johnmarkovalo · 2024-08-09T10:55:53Z

Looking forward with this merge also 👍

Catlike14 · 2025-08-06T10:22:19Z

@jmillan ping?

orgads · 2025-08-13T06:51:55Z

Pushed a rebased version in #922.

jmillan · 2025-12-19T16:23:09Z

lib/Notifier.js

+   * @param {String} body Notify body
+   * @param {Array<string>} extraHeaders
+   */
+  _notify(subsStateParameters, body=null, extraHeaders=null)


private methods must appear after all public ones. Also, this could be called _sendNotify() also to dissambiguate.

jmillan · 2025-12-19T16:25:02Z

lib/Notifier.js

+  /**
+   * Private API
+   */
+  _dialogTerminated(termination_code)


I think terminate() would be a better name for this, as it is what the method does. RTCSession has the same name for such function.

I see terminate() is already taken, then terminateDialog() would work.

jmillan · 2025-12-19T16:29:12Z

@ikq thanks for the patience. I'll try 🤞 to finish the review and accept it in the following weeks. Can I ask you to not include any change in dist/ folder nor in package.json and to sync the branch with master?

jmillan · 2025-12-19T16:34:30Z

lib/Config.js

-  registrar_server : null,
+  register                : true,
+  register_expires        : 600,
+  register_from_tag_trail : '',


Everything related to register_from_tag_trail does not belong to this PR. It's already in master. Please remove it.

jmillan · 2025-12-19T16:34:40Z

lib/Config.js

+    register_from_tag_trail(register_from_tag_trail)
+    {
+      if (typeof register_from_tag_trail === 'function')
+      {
+        return register_from_tag_trail;
+      }
+
+      return String(register_from_tag_trail);
+    },
+


to be removed.

jmillan · 2025-12-19T16:35:08Z

lib/Registrator.js

+    let fromTag = Utils.newTag();
+
+    if (this._ua.configuration.register_from_tag_trail)
+    {
+      if (typeof this._ua.configuration.register_from_tag_trail === 'function')
+      {
+        fromTag += this._ua.configuration.register_from_tag_trail();
+      }
+      else
+      {
+        fromTag += this._ua.configuration.register_from_tag_trail;
+      }
+    }
+
    const request = new SIPMessage.OutgoingRequest(
      JsSIP_C.REGISTER, this._registrar, this._ua, {
-        'to_uri'  : this._to_uri,
-        'call_id' : this._call_id,
-        'cseq'    : (this._cseq += 1)
+        'to_uri'   : this._to_uri,
+        'call_id'  : this._call_id,
+        'cseq'     : (this._cseq += 1),
+        'from_tag' : fromTag


to be removed.

jmillan · 2025-12-19T16:35:18Z

lib/UA.d.ts

  ha1?: string;
  register?: boolean;
  register_expires?: number;
+  register_from_tag_trail?: string | function() : string;


to be removed.

jmillan · 2025-12-19T16:36:01Z

Also please do not edit CHANGELOG.md

jmillan · 2025-12-19T16:41:04Z

lib/RTCSession.js

+            if (finished)
+            {
+              return;
+            }
+


This change does not belong to this PR. It's already in master. Please remove.

jmillan · 2025-12-19T16:41:26Z

lib/RTCSession.js

            }
-
-            else if (!finished)
+            else


Change already in master, please remove.

jmillan · 2025-12-19T16:41:33Z

lib/RTCSession.js

          connection.addEventListener('icegatheringstatechange', iceGatheringStateListener = () =>
          {
-            if ((connection.iceGatheringState === 'complete') && !finished)
+            if (connection.iceGatheringState === 'complete')


Change already in master, please remove.

jmillan · 2025-12-19T16:43:37Z

lib/Notifier.js

+  /**
+   * Get dialog state.
+   */
+  get state()


Getters are set after constructor. Please check RTCSession.js

ikq added 10 commits May 13, 2021 22:16

added subscribe support

ab46c2a

alternative authentication

6469fc3

merged

e8f43c9

subscribe support

503c60c

Merge branch 'subscribe_support' of https://github.com/ikq/JsSIP into…

b9b7f31

… subscribe_support

subscribe support

8ef4afc

Merge branch 'subscribe_support' of https://github.com/ikq/JsSIP into…

be1df6d

… subscribe_support

added subscriber/notifier to JsSIP

6636713

Added Subscriber.js Notifier.js

1220e96

Added Subscriber.js Notifier.js

acf80d7

ikq added 18 commits May 21, 2021 13:54

style changed

2a8e0b1

style changed

b9119ff

Merge branch 'subscribe_support' of https://github.com/ikq/JsSIP into…

ea58279

… subscribe_support

added *.ts definitions

fe32ca3

added *.ts definitions

1ceeb78

edited ts definition

459baa9

subscriber/notifer contact changed

825d6ad

modified Allow-Events

b8ab24c

added check if is_first_notify_request

1e28648

undefined params is supported

55ea3ce

Added comments for public methods

0d5dcdc

added public method comments

d77e41c

added public method argument descriptions

7099def

Notifier: termination reason changed to number

7c935c4

Subscriber termination text changed to code

89fe3d5

changed constant name RECEIVE

15cf6dd

Added missed NOTIFY Contact

a11eb27

Added missed NOTIFY Contact

7db192e

ikq added 3 commits November 5, 2023 17:55

added _notify() that called from notify() and terminate()

aac7d1c

Fixed SUBSCRIPTION_EXPIRED termination functionality

eca25f7

Added reason 'timeout' to user final NOTIFY

b2ef69c

orgads mentioned this pull request Aug 13, 2025

Subscribe support #922

Open

jmillan reviewed Dec 19, 2025

View reviewed changes

lib/Notifier.js

/**

* Get dialog state.

*/

get state()

Copy link

Member

jmillan Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getters are set after constructor. Please check RTCSession.js

Subscribe support #711

Are you sure you want to change the base?

Subscribe support #711

Uh oh!

Conversation

ikq commented May 20, 2021

Uh oh!

jmillan commented May 21, 2021

Uh oh!

jmillan commented May 25, 2021

Uh oh!

devoxy1 commented Nov 15, 2023

Uh oh!

devoxy1 commented Nov 28, 2023

Uh oh!

devoxy1 commented Dec 5, 2023

Uh oh!

ddyner commented Dec 10, 2023

Uh oh!

jmillan commented Dec 11, 2023

Uh oh!

ikq commented Dec 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ikq commented Dec 17, 2023

Uh oh!

devoxy1 commented Jan 9, 2024

Uh oh!

jmillan commented Jan 9, 2024

Uh oh!

jmillan commented Jan 9, 2024

Uh oh!

devoxy1 commented Jan 9, 2024

Uh oh!

jmillan commented Jan 18, 2024

Uh oh!

devoxy1 commented Mar 28, 2024

Uh oh!

orgads commented Jul 23, 2024

Uh oh!

jmillan commented Jul 29, 2024

Uh oh!

johnmarkovalo commented Aug 9, 2024

Uh oh!

Catlike14 commented Aug 6, 2025

Uh oh!

orgads commented Aug 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmillan commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmillan commented Dec 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

ikq commented Dec 11, 2023 •

edited

Loading

jmillan commented Dec 19, 2025 •

edited

Loading