Skip to content

[Snyk] Upgrade org.apache.logging.log4j:log4j-core from 2.13.3 to 2.25.1 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Upgrade org.apache.logging.log4j:log4j-core from 2.13.3 to 2.25.1 #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-core</artifactId>
<version>2.13.3</version>
<version>2.25.1</version>
Copy link

@amazon-q-developer amazon-q-developer bot Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Security Upgrade: This Log4j version upgrade is critical and addresses multiple severe security vulnerabilities1234. The upgrade from 2.13.3 to 2.25.1 resolves two critical Remote Code Execution vulnerabilities, one high-severity Denial of Service vulnerability, and one medium-severity Arbitrary Code Execution vulnerability. This change should be prioritized for immediate deployment.

Footnotes

  1. CWE-94: Code Injection - https://cwe.mitre.org/data/definitions/94.html ↩

  2. CWE-502: Deserialization of Untrusted Data - https://cwe.mitre.org/data/definitions/502.html ↩

  3. CWE-400: Uncontrolled Resource Consumption - https://cwe.mitre.org/data/definitions/400.html ↩

  4. CWE-20: Improper Input Validation - https://cwe.mitre.org/data/definitions/20.html ↩

Copy link

@amazon-q-developer amazon-q-developer bot Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Incomplete Upgrade: While this PR upgrades log4j-core to 2.25.1, the log4j-api dependency (line 53) remains at version 2.13.3. This version mismatch can cause runtime compatibility issues and may not fully resolve all security vulnerabilities. Consider upgrading log4j-api to 2.25.1 as well to ensure consistent behavior and complete security coverage.

Copy link

@amazon-q-developer amazon-q-developer bot Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Additional Security Considerations: While reviewing the dependencies, I noticed several other components that may benefit from security updates: JUnit 4.13.1 (consider upgrading to 4.13.2 or JUnit 5), Mockito 1.10.19 (very outdated), and the JSON library 20200518. Consider running a comprehensive dependency security scan to identify other potential vulnerabilities.

</dependency>
<dependency>
<groupId>org.mockito</groupId>
Expand Down