MAINT: Set SCIPY_ARRAY_API=1 on tests
#2806
Merged
+9
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
4 tasks
david-cortes-intel
requested review from
ahuber21,
icfaust,
napetrov and
yuejiaointel
as code owners
ethanglaser
reviewed
Dec 2, 2025
| # if `array-api-compat` package is present in environment | ||
| # TODO: create generic approach to handle this for all tests | ||
| if sklearn_check_version("1.6"): | ||
| environ["SCIPY_ARRAY_API"] = "1" |
Contributor
Author
There was a problem hiding this comment.
Because it has no effect when done after importing scipy. It is now set from the test runner script instead.
david-cortes-intel
changed the title
SCIPY_ARRAY_API=1 on conda testsSCIPY_ARRAY_API=1 on tests
ethanglaser
approved these changes
Dec 3, 2025
Contributor
|
/intelci: run |
Contributor
|
CI looks good, haven't reviewed in full yet but should be able to by end of week. No objections from my end though. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets env. variable
SCIPY_ARRAY_API=1for the tests runner scripts, which is required in order for all array API functionalities in sklearn to work.Note that some tests were setting this environment variable manually, but it only has an effect when set before scipy is imported, so this logic was actually incorrect:
https://docs.scipy.org/doc/scipy/dev/api-dev/array_api.html
Checklist:
Completeness and readability
Testing