MAINT: Skip conformance tests running with too old array API packages #2803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run Nightly |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
4 tasks
Contributor
Author
|
/azp run Nightly |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
This kind of syntax didn't work - tests were not skipped. @ethanglaser Any ideas about how these conditional skips could be added? |
Contributor
|
I don't believe its possible to deselect based on python, probably makes sense to just deselect entirely and add comment about constraint |
david-cortes-intel
requested review from
ahuber21,
ethanglaser,
icfaust and
yuejiaointel
as code owners
Contributor
Author
Changed to deselect unconditionally. |
ethanglaser
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some tests introduced in sklearn1.8 require versions of array API packages that are not available for older python versions.
Along with bumping the python versions used for the CI jobs that test against the main branch from sklearn, it's also required to skip these problematic tests once sklearn1.8 is released.
This PR tries to deselect the tests based on python versions, but I'm not sure that it will work as intended. Currently, it seems that all of the deselections work only on versions of scikit-learn, and I'm not sure what would be the logic for deselecting based on python versions or versions of other packages instead.
Note that the actual requirement is
array-api-strict>=2.4.1, which in turn requirespython>=3.12.Checklist:
Completeness and readability
Testing