Fix/step order #2153
Open
Fix/step order #2153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Parvinmh is attempting to deploy a commit to the Pean Team on Vercel. A member of the Team first needs to authorize it. |
binrysearch
reviewed
Nov 15, 2025
| step >= this._currentStepSignal.val | ||
| direction === "forward" && | ||
| continueStep === false && | ||
| currentStep !== undefined |
Contributor
There was a problem hiding this comment.
Should this be continueStep === false || currentStep !== undefined?
Consider this case, what if there is a step (currentStep !== undefined) but continueStep is false?
Contributor
Author
There was a problem hiding this comment.
No — it should remain continueStep === false && currentStep !== undefined because we only want to block the step change when the callback explicitly returns false, and there is an existing step to stay on.
Contributor
Author
binrysearch
reviewed
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.