Gmartini/ban 8680 add bulk remove tag from subscriber #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahorovit
approved these changes
Jan 8, 2025
| # @option taggings [String] :tag_id | ||
| # @option taggings [String] :subscriber_id | ||
| def bulk_tag_subscribers(taggings = []) | ||
| def bulk_add_to_subscribers(taggings = []) |
There was a problem hiding this comment.
Not a huge deal, but I chose this name to reflect Kit documentation:
https://developers.kit.com/v4#bulk-tag-subscribers
Otherwise, I think your name is better. We're in the Tags scope, so it's a little redundant to explicitly mention 'tag' in the method name.
I could be convinced to go either way. If we do want to match documentation, the remove method should be called bulk_remove_tags_from_subscribers, which is honestly not a great method name. Again, yours is better, IMO
Author
There was a problem hiding this comment.
I will leave the name as is because I think it is closer to the pattern implemented on this file
gmartinimighty
deleted the
gmartini/BAN-8680-add-bulk-remove-tag-from-subscriber
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.