Skip to content

feat: add TypeScript related extensions support #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add TypeScript related extensions support #85

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc926b4
feat: add TypeScript related extensions support
JounQin Jul 8, 2025
d740285
test: add related docs and tests
JounQin Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/configuration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ const loaders = {
'.cjs': loadScriptOrModule,
'.mjs': loadScriptOrModule,
'.js': loadScriptOrModule,
'.cts': loadScriptOrModule,
'.mts': loadScriptOrModule,
'.ts': loadScriptOrModule,
Copy link
Member

@wooorm wooorm Jul 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not come before .js? Or is it intentional that built JS is preferred over TS

Next to docs, tests are missing

Copy link
Member Author

@JounQin JounQin Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I think js configs should be preferred because they're supported natively and this is just old behavior, what means if a user have a .remarkrc.ts compiled into .remarkrx.js manually, this will continue work even on unsupported Node versions.

Copy link
Member

@wooorm wooorm Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, probably!

'.yaml': loadYaml,
'.yml': loadYaml
}
Expand Down