Skip to content

uui button: ability to set title for button or A-tag #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 7, 2025
Merged

uui button: ability to set title for button or A-tag #1199

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
abf3224
ability to parse title
nielslyngsoe Oct 6, 2025
791c448
only set title if it has a value
nielslyngsoe Oct 6, 2025
6a97a83
only set title if it has a value
nielslyngsoe Oct 6, 2025
7647820
Update packages/uui-button/lib/uui-button.element.ts
nielslyngsoe Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/uui-button/lib/uui-button.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,15 @@ export class UUIButtonElement extends UUIFormControlMixin(
@property({ type: String })
public rel?: string;

/**
* Set the rel attribute for an anchor tag, only used when using href.
* @type {string}
* @attr
* @default undefined
*/
@property({ type: String })
public title: string = '';

@query('#button')
protected _button!: HTMLInputElement;

Expand Down Expand Up @@ -237,6 +246,7 @@ export class UUIButtonElement extends UUIFormControlMixin(
<a
id="button"
aria-label=${ifDefined(this.label)}
title=${ifDefined(this.title === '' ? undefined : this.title)}
href=${ifDefined(!this.disabled ? this.href : undefined)}
target=${ifDefined(this.target || undefined)}
rel=${ifDefined(
Expand All @@ -254,7 +264,8 @@ export class UUIButtonElement extends UUIFormControlMixin(
id="button"
type=${this.type}
?disabled=${this.disabled}
aria-label=${ifDefined(this.label)}>
aria-label=${ifDefined(this.label)}
title=${ifDefined(this.title === '' ? undefined : this.title)}>
${this.renderState()} ${this.renderLabel()}
<slot name="extra"></slot>
</button>
Expand Down
Loading