Skip to content

Conversation

@madsrasmussen
Copy link
Contributor

Description

When adjusting the margin for ref items without an open part, I didn't notice that we had this extra margin when selected. This margin can be removed now because it results in a "double" margin.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@github-actions
Copy link

github-actions bot commented Mar 6, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1037.westeurope.azurestaticapps.net

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2025

@github-actions
Copy link

github-actions bot commented Mar 7, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1037.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe merged commit 9cf891e into v1/contrib Mar 7, 2025
11 of 12 checks passed
@nielslyngsoe nielslyngsoe deleted the v1/bugfix/ref-node-remove-extra-margin branch March 7, 2025 10:37
iOvergaard pushed a commit that referenced this pull request Mar 11, 2025
* remove extra margin

* Update uui-ref-node.element.ts

Co-authored-by: Mads Rasmussen <mra@umbraco.dk>
@iOvergaard iOvergaard added the bug Something isn't working label Mar 11, 2025
nielslyngsoe pushed a commit that referenced this pull request Mar 20, 2025
* remove extra margin

* Update uui-ref-node.element.ts
iOvergaard pushed a commit that referenced this pull request Mar 24, 2025
* Fix: Remove extra margin on ref-node (#1037)

* remove extra margin

* Update uui-ref-node.element.ts

* fallback render select border

* make default render of uui-card include the select border

---------

Co-authored-by: Mads Rasmussen <mra@umbraco.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants