Skip to content

fix: Make disabled menu item button more clear #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 14, 2025
Merged

fix: Make disabled menu item button more clear #1034

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2536105
make disabled menu item button more clear
LanThuyNguyen Mar 5, 2025
b9df953
Update packages/uui-menu-item/lib/uui-menu-item.element.ts
iOvergaard Mar 14, 2025
7b67a25
Merge branch 'v1/contrib' into v1/fix-bug/make-disabled-tree-node-mor…
iOvergaard Mar 14, 2025
18f36f9
fix: set opacity a bit lower
iOvergaard Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/uui-menu-item/lib/uui-menu-item.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,10 +311,6 @@ export class UUIMenuItemElement extends SelectOnlyMixin(

/** Disabled */
:host([disabled]) #menu-item {
color: var(
--uui-menu-item-color-disabled,
var(--uui-color-disabled-contrast)
);
background-color: var(
--uui-menu-item-background-color-disabled,
var(--uui-color-disabled)
Expand Down Expand Up @@ -467,6 +463,7 @@ export class UUIMenuItemElement extends SelectOnlyMixin(

:host([disabled]) #label-button {
cursor: default;
opacity: 0.4;
}

button {
Expand Down
Loading