Skip to content

Fix #20944: Updating UI Slider number properties to accept decimal values #20945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+19 −14
Open

Fix #20944: Updating UI Slider number properties to accept decimal values #20945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ece2b49
updating UI slider properties min, max, initial1, initial2 and step t…
jsandrae Nov 24, 2025
0ad28f0
Changes based on Copilot suggestions
jsandrae Nov 24, 2025
9e134ae
Merge branch 'main' into v16/allow-decimals-in-slider-properties
nielslyngsoe Nov 25, 2025
7f572c3
Merge branch 'main' into v16/allow-decimals-in-slider-properties
nielslyngsoe Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/Umbraco.Web.UI.Client/src/packages/property-editors/slider/Umbraco.Slider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,20 @@ export const manifest: ManifestPropertyEditorSchema = {
alias: 'minVal',
label: 'Minimum value',
description: '',
propertyEditorUiAlias: 'Umb.PropertyEditorUi.Integer',
propertyEditorUiAlias: 'Umb.PropertyEditorUi.Decimal',
config: [{ alias: 'step', value: '0.001' }],
},
{
alias: 'maxVal',
label: 'Maximum value',
description: '',
propertyEditorUiAlias: 'Umb.PropertyEditorUi.Integer',
propertyEditorUiAlias: 'Umb.PropertyEditorUi.Decimal',
config: [{ alias: 'step', value: '0.001' }],
},
],
defaultData: [
{ alias: 'minVal', value: 0 },
{ alias: 'maxVal', value: 100 },
{ alias: 'minVal', value: 0.0 },
{ alias: 'maxVal', value: 100.0 },
],
},
},
Expand Down
15 changes: 9 additions & 6 deletions src/Umbraco.Web.UI.Client/src/packages/property-editors/slider/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,33 +31,36 @@ export const manifests: Array<UmbExtensionManifest> = [
alias: 'initVal1',
label: 'Initial value',
description: '',
propertyEditorUiAlias: 'Umb.PropertyEditorUi.Integer',
propertyEditorUiAlias: 'Umb.PropertyEditorUi.Decimal',
config: [{ alias: 'step', value: '0.001' }],
Copy link
Member

@nielslyngsoe nielslyngsoe Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR. But is it safe to assume that having 3 decimals is enough to cover all cases?
I'm not sure, but I will leave this thought up for those reviewing( or something with oppinions coming by)

},
{
alias: 'initVal2',
label: 'Initial value 2',
description: 'Used when range is enabled',
propertyEditorUiAlias: 'Umb.PropertyEditorUi.Integer',
propertyEditorUiAlias: 'Umb.PropertyEditorUi.Decimal',
config: [{ alias: 'step', value: '0.001' }],
},
{
alias: 'step',
label: 'Step increments',
description: '',
propertyEditorUiAlias: 'Umb.PropertyEditorUi.Integer',
propertyEditorUiAlias: 'Umb.PropertyEditorUi.Decimal',
config: [{ alias: 'step', value: '0.001' }],
},
],
defaultData: [
{
alias: 'initVal1',
value: 0,
value: 0.0,
},
{
alias: 'initVal2',
value: 0,
value: 0.0,
},
{
alias: 'step',
value: 1,
value: 1.0,
},
],
},
Expand Down
8 changes: 4 additions & 4 deletions ...o.Web.UI.Client/src/packages/property-editors/slider/property-editor-ui-slider.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ export class UmbPropertyEditorUISliderElement
const initVal2 = Number(config.getValueByAlias('initVal2'));
this._initVal2 = isNaN(initVal2) ? this._initVal1 + this._step : initVal2;

this._min = this.#parseInt(config.getValueByAlias('minVal')) || 0;
this._max = this.#parseInt(config.getValueByAlias('maxVal')) || 100;
this._min = this.#parseNumber(config.getValueByAlias('minVal')) || 0;
this._max = this.#parseNumber(config.getValueByAlias('maxVal')) || 100;

if (this._min === this._max) {
this._max = this._min + 100;
Expand Down Expand Up @@ -137,9 +137,9 @@ export class UmbPropertyEditorUISliderElement
}
}

#parseInt(input: unknown): number | undefined {
#parseNumber(input: unknown): number | undefined {
const num = Number(input);
return Number.isNaN(num) ? undefined : num;
return Number.isFinite(num) ? undefined : num;
}

#onChange(event: CustomEvent & { target: UmbInputSliderElement }) {
Expand Down
Loading