-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Content Type Workspace: Create condition that checks content type uniques. #20906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Content Type Workspace: Create condition that checks content type uniques. #20906
Conversation
…' of https://github.com/umbraco/Umbraco-CMS into v17/improvement/workspace-content-type-unique-condition
madsrasmussen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @engijlr
This looks really good! I have a bit of trouble running the example because of a const import that points to something wrong, but the code looks like it does what it should.
I have added a few comments around code style and naming where I think we can make some improvements for alignment and readability.
Let me know when you have had a look at the example, then I will try it again.
src/Umbraco.Web.UI.Client/examples/entity-content-type-condition/index.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/examples/entity-content-type-condition/index.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/examples/entity-content-type-condition/index.ts
Outdated
Show resolved
Hide resolved
...orkspace/conditions/workspace-content-type-unique/workspace-content-type-unique.condition.ts
Outdated
Show resolved
Hide resolved
...orkspace/conditions/workspace-content-type-unique/workspace-content-type-unique.condition.ts
Outdated
Show resolved
Hide resolved
...mbraco.Web.UI.Client/examples/entity-content-type-condition/workspace-view-unique.element.ts
Outdated
Show resolved
Hide resolved
...mbraco.Web.UI.Client/examples/entity-content-type-condition/workspace-view-unique.element.ts
Outdated
Show resolved
Hide resolved
...mbraco.Web.UI.Client/examples/entity-content-type-condition/workspace-view-unique.element.ts
Outdated
Show resolved
Hide resolved
…on/index.ts Co-authored-by: Mads Rasmussen <madsr@hey.com>
…on/workspace-view-unique.element.ts Co-authored-by: Mads Rasmussen <madsr@hey.com>
…' of https://github.com/umbraco/Umbraco-CMS into v17/improvement/workspace-content-type-unique-condition
Summary
Adds a new workspace condition Umb.Condition.WorkspaceContentTypeUnique that checks content types by their GUID/unique identifier instead of alias.
How to test
npm run exampleand choose option 6 - entity-content-type-condition