Skip to content

Collection Item Picker: support icon colors #20787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
Merged

Collection Item Picker: support icon colors #20787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4962477
Update icon usage in collection menu and example data
madsrasmussen Nov 11, 2025
127f920
Merge branch 'release/17.0' into v17/hotfix/collection-item-picker-re…
nielslyngsoe Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...Web.UI.Client/examples/picker-data-source/example-custom-picker-collection-data-source.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,35 +53,35 @@ const customItems: Array<ExampleCollectionItemModel> = [
unique: '1',
entityType: 'example',
name: 'Example 1',
icon: 'icon-shape-triangle',
icon: 'icon-shape-triangle yellow',
isPickable: true,
},
{
unique: '2',
entityType: 'example',
name: 'Example 2',
icon: 'icon-shape-triangle',
icon: 'icon-shape-triangle yellow',
isPickable: true,
},
{
unique: '3',
entityType: 'example',
name: 'Example 3',
icon: 'icon-shape-triangle',
icon: 'icon-shape-triangle yellow',
isPickable: true,
},
{
unique: '4',
entityType: 'example',
name: 'Example 4',
icon: 'icon-shape-triangle',
icon: 'icon-shape-triangle yellow',
isPickable: false,
},
{
unique: '5',
entityType: 'example',
name: 'Example 5',
icon: 'icon-shape-triangle',
icon: 'icon-shape-triangle yellow',
isPickable: true,
},
];
4 changes: 1 addition & 3 deletions ...c/packages/core/collection/menu/menu-item/default/default-collection-menu-item.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,7 @@ export class UmbDefaultCollectionMenuItemElement extends UmbLitElement {
?selected=${this._isSelected}
@selected=${() => this.#api?.select()}
@deselected=${() => this.#api?.deselect()}>
${item.icon
? html`<uui-icon slot="icon" name=${item.icon}></uui-icon>`
: html`<uui-icon slot="icon" name=${getItemFallbackIcon()}></uui-icon>`}
<umb-icon slot="icon" name=${item.icon ?? getItemFallbackIcon()}></umb-icon>
</uui-menu-item>
`;
}
Expand Down
Loading