-
Notifications
You must be signed in to change notification settings - Fork 4
Expand hints with better pickle bits and use it to cover create_user. #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
836ed71 to
524830d
Compare
jonasbardino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine except for the missing mandatory docstrings.
524830d to
45f51fb
Compare
|
Thanks for adding the missing docstrings. I did another review pass and found a few other bits to address so that we can land it. |
Thanks for going over it, have responded to the points. And of course on the docstrings - this test was pulled out and adapted from a 2024 branch hence a few being missing. |
Provide a means to load pickled data from disk to which the hints mechanism as introduced for fixtures can be applied. Extensively document the rationale for hinting in light of expansion of this facility and its re-use. Use all the facilities for a test covering useradm create_user function. Note, create_user is mostly about writing rather than the population of the user dictionary with a majority of the important prep work with regard to what will be written being done by the calling script. This means that the we are only comparing written data as of now, meaning it is something of a loose test, but this towards additional rigour. Note that we used the opportunity to make sure that calling create_user writes exactly what was declared within our on-disk user fixture. This begins to verify the fixture itself and strenghtens the assurances of any test consuming that fixture (to the extent allowed given the responsibilities of create_user noted above - a start).
45f51fb to
1342d84
Compare
Provide a means to load pickled data from disk to which the hints
mechanism as introduced for fixtures can be applied. Extensively
document the rationale for hinting in light of expansion of this
facility and its re-use.
Use all the facilities for a test covering useradm create_user function.
Note, create_user is mostly about writing rather than the population
of the user dictionary with a majority of the important prep work with
regard to what will be written being done by the calling script. This
means that the we are only comparing written data as of now, meaning it
is something of a loose test, but this towards additional rigour.
Note that we used the opportunity to make sure that calling create_user
writes exactly what was declared within our on-disk user fixture. This
begins to verify the fixture itself and strenghtens the assurances of
any test consuming that fixture (to the extent allowed given the
responsibilities of create_user noted above - a start).