Skip to content

Conversation

@albu-diku
Copy link
Contributor

@albu-diku albu-diku commented Oct 25, 2025

Provide a means to load pickled data from disk to which the hints
mechanism as introduced for fixtures can be applied. Extensively
document the rationale for hinting in light of expansion of this
facility and its re-use.

Use all the facilities for a test covering useradm create_user function.
Note, create_user is mostly about writing rather than the population
of the user dictionary with a majority of the important prep work with
regard to what will be written being done by the calling script. This
means that the we are only comparing written data as of now, meaning it
is something of a loose test, but this towards additional rigour.

Note that we used the opportunity to make sure that calling create_user
writes exactly what was declared within our on-disk user fixture. This
begins to verify the fixture itself and strenghtens the assurances of
any test consuming that fixture (to the extent allowed given the
responsibilities of create_user noted above - a start).

@albu-diku albu-diku force-pushed the test/useradm-create_user branch from 836ed71 to 524830d Compare October 25, 2025 13:54
Copy link
Contributor

@jonasbardino jonasbardino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine except for the missing mandatory docstrings.

@albu-diku albu-diku force-pushed the test/useradm-create_user branch from 524830d to 45f51fb Compare October 27, 2025 11:15
@jonasbardino
Copy link
Contributor

Thanks for adding the missing docstrings. I did another review pass and found a few other bits to address so that we can land it.

@jonasbardino jonasbardino self-assigned this Oct 29, 2025
@jonasbardino jonasbardino added the test-only Improvements or additions solely for better test coverage - without functionality changes label Oct 29, 2025
@albu-diku
Copy link
Contributor Author

Thanks for adding the missing docstrings. I did another review pass and found a few other bits to address so that we can land it.

Thanks for going over it, have responded to the points. And of course on the docstrings - this test was pulled out and adapted from a 2024 branch hence a few being missing.

@albu-diku albu-diku changed the title Add test covering the useradm create_user function. Expand hints with better pickle bits and use it to cover create_user. Nov 5, 2025
Provide a means to load pickled data from disk to which the hints
mechanism as introduced for fixtures can be applied. Extensively
document the rationale for hinting in light of expansion of this
facility and its re-use.

Use all the facilities for a test covering useradm create_user function.
Note, create_user is mostly about writing rather than the population
of the user dictionary with a majority of the important prep work with
regard to what will be written being done by the calling script. This
means that the we are only comparing written data as of now, meaning it
is something of a loose test, but this towards additional rigour.

Note that we used the opportunity to make sure that calling create_user
writes exactly what was declared within our on-disk user fixture. This
begins to verify the fixture itself and strenghtens the assurances of
any test consuming that fixture (to the extent allowed given the
responsibilities of create_user noted above - a start).
@albu-diku albu-diku force-pushed the test/useradm-create_user branch from 45f51fb to 1342d84 Compare November 5, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-only Improvements or additions solely for better test coverage - without functionality changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants