Fundamental test coverage of vgridaccess.py. #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasbardino
added
the
test-only
jonasbardino
force-pushed
the
add/mig-shared-vgridaccess-unit-tests
branch
from
e50cda8 to
d8c3e0e
Compare
…ecessary clean function arguments.
…picked up by the traversal in map updates. Add basic load_X_map tests.
…ested functions and increase basic coverage.
…undant assertions.
…and verify that each test really has a clean environment to rule out CI test failures due to stale data.
jonasbardino
force-pushed
the
add/mig-shared-vgridaccess-unit-tests
branch
from
d8c3e0e to
188e4b8
Compare
…y get reset in between tests.
…ll vgrids are fully populated with the vgrid_home/X pickles like after createvgrid call.
…trict checking that created vgrids are really always in vgrid map after initial force_update_vgrid_map calls to rule out issues there in relation to remaining inconsistent CI errors.
speculated in that PR description. We would prefer to avoid mixing them up in this test-only PR but unfortunately I'm completely unable to trigger similar failures locally. So if it solves the problems I'll merge PR #380 and rebase this one on it before merge to keep them apart.
…may in fact have fixed the spurious `OWNERS` errors in CI unit tests. Extend the vgridaccess fix from PR #380 to apply similar fixes in the the `RESOURCES` and `USER` update loop of refresh_vgrid_map.
jonasbardino
added a commit
that referenced
this pull request
Nov 2, 2025
…vgrid_map` as recently introduced for the `VGRIDS` update there. It appears to also solve the last remaining spurious test errors in CI for PR #372.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fundamental test coverage of
vgridaccess.py.