Skip to content

Conversation

@albu-diku
Copy link
Contributor

Based on a response to a small cleanup attempt in acwrapper (#350 (comment)) it seems it is better to remove this code and its callsites. Do so here.

@albu-diku
Copy link
Contributor Author

@jonasbardino I've attempted to carefully perform the removal here, incluing any blocks that conditionally ventured into ARC related things.

The only area I'm not clear on how to handle is mig/shared/mrsltoxsl.py where there are lots of references to arclib that I'm pretty sure would no longer be relevan, but I'm not completel certain what's safe to cut.

@jonasbardino
Copy link
Contributor

@jonasbardino I've attempted to carefully perform the removal here, incluing any blocks that conditionally ventured into ARC related things.

The only area I'm not clear on how to handle is mig/shared/mrsltoxsl.py where there are lots of references to arclib that I'm pretty sure would no longer be relevan, but I'm not completel certain what's safe to cut.

Thanks, the mig/shared/mrsltoxsl.py is arc-specific and should just be purged as well.

@jonasbardino
Copy link
Contributor

jonasbardino commented Oct 13, 2025

The linting errors here are old and fixing them is covered in PR #338 and #363.

UPDATE: Rebasing after merging #363 indeed resolved those issues.

jonasbardino added a commit that referenced this pull request Oct 13, 2025
@jonasbardino jonasbardino force-pushed the refactor/remove-arcwrapper branch from 49fee3d to 182c8ea Compare October 17, 2025 09:52
@albu-diku
Copy link
Contributor Author

@jonasbardino have update this to the tip of next via the GitHub UI. Was there anything else that you’d wanted here? Otherwise reckon it’ll be nice to move this hunk of unused stuff out of the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants