-
-
Notifications
You must be signed in to change notification settings - Fork 27
perf(abg): create JARs only when they are actually requested #1615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 20, 2024
Collaborator
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 20, 2024
08293c4 to
e888756
Compare
9b85609 to
f4e253b
Compare
e888756 to
748f7ac
Compare
f4e253b to
bd4ecb7
Compare
748f7ac to
084ba53
Compare
bd4ecb7 to
57aefbd
Compare
084ba53 to
af4c964
Compare
57aefbd to
23eab1b
Compare
af4c964 to
4f1ca6a
Compare
23eab1b to
b99bf8e
Compare
4f1ca6a to
01bfd2c
Compare
b99bf8e to
d909c4e
Compare
b3c62ce to
527c76a
Compare
krzema12
reviewed
Aug 31, 2024
...nding-builder/src/main/kotlin/io/github/typesafegithub/workflows/mavenbinding/JarBuilding.kt
Show resolved
Hide resolved
4be4e64 to
ee7d17c
Compare
527c76a to
35bff5a
Compare
ee7d17c to
236983f
Compare
35bff5a to
b0049d7
Compare
236983f to
9c6721a
Compare
b0049d7 to
28d8de9
Compare
9c6721a to
88841f3
Compare
28d8de9 to
49ccdad
Compare
88841f3 to
94a180c
Compare
49ccdad to
c988e74
Compare
94a180c to
7c554ae
Compare
c988e74 to
90814cf
Compare
7c554ae to
69a4815
Compare
da86cc7 to
f173834
Compare
7d05583 to
6955515
Compare
6955515 to
6e2e4fc
Compare
krzema12
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

In some cases, only e.g. a POM is necessary to fetch for a given action. Thanks to this change, no Kotlin compilation or JAR creation will happen when requesting an artifact that doesn't require it.