Measure metrics using otel4s
#396
Conversation
rossabaker
left a comment
rossabaker
left a comment
There was a problem hiding this comment.
This is super cool. I have some bad feelings about the incs and decs and >> and how they play with cancellation.
core/src/main/scala/org/typelevel/keypool/internal/Metrics.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/typelevel/keypool/internal/Metrics.scala
Outdated
Show resolved
Hide resolved
# Conflicts: # core/src/main/scala/org/typelevel/keypool/KeyPool.scala # core/src/main/scala/org/typelevel/keypool/KeyPoolBuilder.scala
core/.jvm/src/test/scala/org/typelevel/keypool/PoolMetricsSpec.scala
Outdated
Show resolved
Hide resolved
# Conflicts: # build.sbt # core/src/main/scala/org/typelevel/keypool/KeyPool.scala # core/src/main/scala/org/typelevel/keypool/KeyPoolBuilder.scala
# Conflicts: # build.sbt # core/shared/src/test/scala/org/typelevel/keypool/KeyPoolSpec.scala
iRevive
changed the title
otel4sotel4s
# Conflicts: # build.sbt
|
Very nice PR! .. I see very useful for measuring acquire durations for skunk and ember http4s client connections. Would it also work for doobie ? And would this work for prometheus as well ? I guess implementing the What's needed to finish this one, maybe we can offer help. |
@Fristi We're still working towards a stable release of otel4s :) lots to do!
Does doobie do its own pooling? I would have thought this happens in the underlying JDBC connectors. |
|
Hikari is being used .. but @ChristopherDavenport wrote doobie-pool which is also keyedpool https://github.com/ChristopherDavenport/doobie-pool/blob/master/core/src/main/scala/io/chrisdavenport/doobiepool/PooledTransactor.scala |
# Conflicts: # .github/workflows/ci.yml # build.sbt
# Conflicts: # .github/workflows/ci.yml # build.sbt # core/shared/src/main/scala/org/typelevel/keypool/KeyPool.scala
iRevive
changed the title
otel4sotel4s
|
The PR is ready to be reviewed. |
|
@danicheg could you please take a look? |
|
The otel4s is still in active development. While I expect the future releases of the As an alternative, we can move forward only with the |
4 participants
Experimental integration with https://github.com/typelevel/otel4s.
The tests are green locally.