Add proxy support to HTTP Client #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case we are being blocked by a domain we need to be able to use a proxy.
Make sure that the proxy is configured properly when added to client.
Add a proxy server and a target server to enable tests for ensuring requests are routed trough proxy
Implement shared examples for proxy configuration and routing
roback
reviewed
Mar 11, 2025
roback
reviewed
Mar 12, 2025
Member
roback
left a comment
roback
left a comment
There was a problem hiding this comment.
Some small comments, but other than that I think everything here looks good 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to route HTTP requests through a proxy server.
Changes
proxyparameter toTwingly::HTTP::ClientinitializationTests