Skip to content

chore: URL query percent encoded #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+119 −23
Open

chore: URL query percent encoded #769

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
87cba89
chore: URL query percent encoded
manisha1997 Dec 2, 2025
79326fb
chore: URL query percent encoded
manisha1997 Dec 2, 2025
4f52ffc
chore: URL query percent encoded
manisha1997 Dec 2, 2025
e5d8ec3
Merge branch 'main' into url-query-parameters-encoded
manisha1997 Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-and-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
timeout-minutes: 20
strategy:
matrix:
ruby: [ '2.4', '2.5', '2.6', '2.7', '3.0', '3.1', '3.2', 'jruby-9.3', 'jruby-9.4' ]
ruby: [ '2.5', '2.6', '2.7', '3.0', '3.1', '3.2', 'jruby-9.3', 'jruby-9.4' ]
steps:
- name: Checkout twilio-ruby
uses: actions/checkout@v3
Expand Down
140 changes: 118 additions & 22 deletions spec/framework/request_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,36 +1,132 @@
require 'spec_helper'

describe Twilio::Request do
before do
@request = Twilio::Request.new('host',
'port',
'POST',
'url',
{ 'param-key' => 'param-value', 'param-keytwo' => 'param-valuetwo' },
{ 'data-key' => 'data-value', 'data-keytwo' => 'data-valuetwo' },
{ 'header-key' => 'header-value', 'header-keytwo' => 'header-valuetwo' },
['a', 'b'],
'timeout')
end

it 'should initialize readers correctly' do
expect(@request.host).to eq('host')
expect(@request.port).to eq('port')
expect(@request.method).to eq('POST')
expect(@request.url).to eq('url')
expect(@request.params).to eq('param-key' => 'param-value', 'param-keytwo' => 'param-valuetwo')
expect(@request.data).to eq('data-key' => 'data-value', 'data-keytwo' => 'data-valuetwo')
expect(@request.headers).to eq('header-key' => 'header-value', 'header-keytwo' => 'header-valuetwo')
expect(@request.auth).to eq(['a', 'b'])
expect(@request.timeout).to eq('timeout')
request = Twilio::Request.new('host',
'port',
'POST',
'url',
{ 'param-key' => 'param-value', 'param-keytwo' => 'param-valuetwo' },
{ 'data-key' => 'data-value', 'data-keytwo' => 'data-valuetwo' },
{ 'header-key' => 'header-value', 'header-keytwo' => 'header-valuetwo' },
['a', 'b'],
'timeout')
expect(request.host).to eq('host')
expect(request.port).to eq('port')
expect(request.method).to eq('POST')
expect(request.url).to eq('url')
expect(request.params).to eq('param-key' => 'param-value', 'param-keytwo' => 'param-valuetwo')
expect(request.data).to eq('data-key' => 'data-value', 'data-keytwo' => 'data-valuetwo')
expect(request.headers).to eq('header-key' => 'header-value', 'header-keytwo' => 'header-valuetwo')
expect(request.auth).to eq(['a', 'b'])
expect(request.timeout).to eq('timeout')
end

it 'should be represented correctly' do
request = Twilio::Request.new('host',
'port',
'POST',
'url',
{ 'param-key' => 'param-value', 'param-keytwo' => 'param-valuetwo' },
{ 'data-key' => 'data-value', 'data-keytwo' => 'data-valuetwo' },
{ 'header-key' => 'header-value', 'header-keytwo' => 'header-valuetwo' },
['a', 'b'],
'timeout')
expected_string = %((a,b) POST url?param-key=param-value&param-keytwo=param-valuetwo) +
%(\n-d "data-key"="data-value") +
%(\n-d "data-keytwo"="data-valuetwo") +
%(\n-H "header-key": "header-value") +
%(\n-H "header-keytwo": "header-valuetwo")
expect(@request.to_s).to eq(expected_string)
expect(request.to_s).to eq(expected_string)
end

it 'should be percent encode properly' do
request = Twilio::Request.new('host',
'port',
'POST',
'url',
{ 'param-key' => ':/?#[]@' },
{ 'data-key' => 'data-value', 'data-keytwo' => 'data-valuetwo' },
{ 'header-key' => 'header-value', 'header-keytwo' => 'header-valuetwo' },
['a', 'b'],
'timeout')
expected_string = %((a,b) POST url?param-key=%3A%2F%3F%23%5B%5D%40) +
%(\n-d "data-key"="data-value") +
%(\n-d "data-keytwo"="data-valuetwo") +
%(\n-H "header-key": "header-value") +
%(\n-H "header-keytwo": "header-valuetwo")
expect(request.to_s).to eq(expected_string)
end

it 'should be percent encode properly for sub delimiters' do
request = Twilio::Request.new('host',
'port',
'POST',
'url',
{ 'param-key' => '!$&\'()*+,;=' },
{ 'data-key' => 'data-value', 'data-keytwo' => 'data-valuetwo' },
{ 'header-key' => 'header-value', 'header-keytwo' => 'header-valuetwo' },
['a', 'b'],
'timeout')
expected_string = %((a,b) POST url?param-key=%21%24%26%27%28%29%2A%2B%2C%3B%3D) +
%(\n-d "data-key"="data-value") +
%(\n-d "data-keytwo"="data-valuetwo") +
%(\n-H "header-key": "header-value") +
%(\n-H "header-keytwo": "header-valuetwo")
expect(request.to_s).to eq(expected_string)
end

it 'should be percent encode percent encode' do
request = Twilio::Request.new('host',
'port',
'POST',
'url',
{ 'param-key' => '%25' },
{ 'data-key' => 'data-value', 'data-keytwo' => 'data-valuetwo' },
{ 'header-key' => 'header-value', 'header-keytwo' => 'header-valuetwo' },
['a', 'b'],
'timeout')
expected_string = %((a,b) POST url?param-key=%2525) +
%(\n-d "data-key"="data-value") +
%(\n-d "data-keytwo"="data-valuetwo") +
%(\n-H "header-key": "header-value") +
%(\n-H "header-keytwo": "header-valuetwo")
expect(request.to_s).to eq(expected_string)
end

it 'should be not percent encode these characters' do
request = Twilio::Request.new('host',
'port',
'POST',
'url',
{ 'param-key' => '-._~' },
{ 'data-key' => 'data-value', 'data-keytwo' => 'data-valuetwo' },
{ 'header-key' => 'header-value', 'header-keytwo' => 'header-valuetwo' },
['a', 'b'],
'timeout')
expected_string = %((a,b) POST url?param-key=-._~) +
%(\n-d "data-key"="data-value") +
%(\n-d "data-keytwo"="data-valuetwo") +
%(\n-H "header-key": "header-value") +
%(\n-H "header-keytwo": "header-valuetwo")
expect(request.to_s).to eq(expected_string)
end

it 'tests parameter sanitation by encoding to prevent injection and XSS attacks' do
request = Twilio::Request.new('host',
'port',
'POST',
'url',
{ 'param-key' => 'https://malicious.com/?q=<script>alert("xss")</script>' },
{ 'data-key' => 'data-value', 'data-keytwo' => 'data-valuetwo' },
{ 'header-key' => 'header-value', 'header-keytwo' => 'header-valuetwo' },
['a', 'b'],
'timeout')
expected_string = %((a,b) POST url?param-key=https%3A%2F%2Fmalicious.com%2F%3Fq%3D%3Cscript%3Ealert%28%22xss%22%29%3C%2Fscript%3E) +
%(\n-d "data-key"="data-value") +
%(\n-d "data-keytwo"="data-valuetwo") +
%(\n-H "header-key": "header-value") +
%(\n-H "header-keytwo": "header-valuetwo")
expect(request.to_s).to eq(expected_string)
end
end
Loading