test: Add comprehensive delete method status code tests #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Co-authored-by: manisha1997 <28821901+manisha1997@users.noreply.github.com>
Co-authored-by: manisha1997 <28821901+manisha1997@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update supporting all status codes for delete
test: Add comprehensive delete method status code tests
Dec 1, 2025
Copilot finished work on behalf of
manisha1997
December 1, 2025 13:59
manisha1997
merged commit aa67292
into
support-all-status-codes-for-delete
4 checks passed
manisha1997
added a commit
that referenced
this pull request
Dec 4, 2025
* chore: Support all status codes for delete * test: Add comprehensive delete method status code tests (#767) * Initial plan * Add comprehensive tests for delete method with various status codes Co-authored-by: manisha1997 <28821901+manisha1997@users.noreply.github.com> * Add vendor/bundle to .gitignore and remove from repository Co-authored-by: manisha1997 <28821901+manisha1997@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: manisha1997 <28821901+manisha1997@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: manisha1997 <28821901+manisha1997@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #766 (partial - addresses review feedback)
Adds test coverage for the delete method's expanded status code acceptance (2xx/3xx) introduced in PR #766.
Checklist
Changes
spec/framework/version_spec.rbcovering:.gitignoreto excludevendor/bundleTests verify the delete method now accepts all 2xx and 3xx status codes while properly raising errors for 4xx/5xx, validating the behavior change from accepting only 204 to the expanded range.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.