Skip to content

chore: Support all status codes for delete #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2025
Merged

chore: Support all status codes for delete #766

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b11173
chore: Support all status codes for delete
manisha1997 Dec 1, 2025
aa67292
test: Add comprehensive delete method status code tests (#767)
Copilot Dec 1, 2025
f10adca
Merge branch 'main' into support-all-status-codes-for-delete
manisha1997 Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/twilio-ruby/framework/rest/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,11 @@ def delete(method, uri, params: {}, data: {}, headers: {}, auth: nil, timeout: n
timeout
)

if response.status_code < 200 || response.status_code >= 300
if response.status_code < 200 || response.status_code >= 400
raise exception(response, 'Unable to delete record')
end

response.status_code == 204
response.status_code >= 200 && response.status_code < 400
end

def read_limits(limit = nil, page_size = nil)
Expand Down
Loading